On Tue, 10 May 2016 12:22:47 -0400 (EDT)
Bastien Nocera <bnocera(a)redhat.com> wrote:
----- Original Message -----
> Greetings.
>
> This friday (2016-05-13) at 16UTC we will be migrating:
>
>
https://fedorahosted.org/comps/
>
https://fedorahosted.org/spin-kickstarts/
>
> to
>
>
https://pagure.io/fedora-comps/
>
https://pagure.io/fedora-kickstarts/
>
> With this migration we will be changing the workflow for
> changes to these repositories from a simple commit model
> to a pull request model. This means in order to make some
> change you should submit a pull request, which will be reviewed
> by at least one other person and then pushed live into the
> repo. Initially commit on these new repos will be set to
> the pagure releng group, but more people will be added as needed.
>
> This model will allow us to run CI tests on Pull Requests and
> confirm that they are not going to cause syntax errors
At least syntax errors could have been dealt with a git hook
server side.
yep. Thats planned. Along with hopefully down the road things like test
composes that show size changes and such.
> or other simple breakage. Additionally, this will allow us
> to properly handle changes to these repos during milestone
> Freezes (getting approval for a freeze break before pushing
> changes, etc).
>
> With the migration of the fedora-kickstarts project we will
> also be trying to identify owner(s) for each kickstart file.
> This will allow us to properly assign issues to the
> folks that can address them.
Are those unwanted or broken changes something that happened that
often that we'd want to have this level of review for the patches,
but for me it would probably be any barrier to contribution.
Well, it was/is definitely troublesome during freezes as people could
(and did) make changes so say we had a RC1, and fixed 1 blocker and did
a RC2, and between the two some spins changed a bunch or broke.
Making PR's doesn't take that long...
kevin