-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1771/#review2702
-----------------------------------------------------------
Apart from a minor namespace clash, it looks fine.
src/libs/libopenlmi/openlmi-utils.h
<
http://reviewboard-openlmi.rhcloud.com/r/1771/#comment1499>
This is more a recommendation: please do not mix namespaces, i.e. g_* belongs to glib,
similar to gtk_*. It's an unwritten rule from the past experience, when functions with
same names have been introduced later, causing build failures.
In this case with such complicated names, it's highly unlikely though.
src/libs/libopenlmi/openlmi-utils.h
<
http://reviewboard-openlmi.rhcloud.com/r/1771/#comment1500>
Related to the note above, this one could cause conflict. Please choose a different
namespace, e.g. lmi_ or prepend with an underscore (--> _g_tree_peek_first).
src/libs/libopenlmi/openlmi-utils.c
<
http://reviewboard-openlmi.rhcloud.com/r/1771/#comment1501>
Hint: if you don't mind extra memory (de-)allocation, have a look at
g_ascii_strdown()
- Tomáš Bžatek
On Čer. 10, 2014, 8:18 dop., Michal Minar wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1771/
-----------------------------------------------------------
(Updated Čer. 10, 2014, 8:18 dop.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
added openlmi-utils to openlmicommon library
Diffs
-----
src/libs/libopenlmi/CMakeLists.txt 867260ebdc3693b205044a0271d8c1e1bd74b59d
src/libs/libopenlmi/openlmi-utils.h PRE-CREATION
src/libs/libopenlmi/openlmi-utils.c PRE-CREATION
Diff:
http://reviewboard-openlmi.rhcloud.com/r/1771/diff/
Testing
-------
Thanks,
Michal Minar