-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1147/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
software - tests: software test suite with basic tests
This is only a "current-status" review. I'll be very thankful for any comments on what's wrong, how the structure should look like, etc.
My TODO is to
* repair all broken tests
* add all tests mentioned
* bind test suite with new LmiTestCase class
I apologize for inconvenience, but I wasn't able to save previous review notes.
Diffs
-----
src/software/test/lmi-test.repo PRE-CREATION
src/software/test/testSoftware.py PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1147/diff/
Testing
-------
Thanks,
Jan Grec
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/314/
-----------------------------------------------------------
(Updated July 3, 2013, 12:03 p.m.)
Status
------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
-------
Add .reviewboardrc configuration file
Also removes the overly-agressive .* entry in .gitignore, since it prevents updates to the .gitignore and .reviewboardrc files.
Diffs
-----
.gitignore 5c8cb4947de0a5845db267b5490de2bd29f4b35f
.reviewboardrc PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/314/diff/
Testing
-------
Submitted this review via post-review using this configuration file.
Thanks,
Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/854/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Account: Added QA test for account provider.
Diffs
-----
src/account/test/testAccount.py PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/854/diff/
Testing
-------
Thanks,
Robin Hack
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/874/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Account: Better failure check of lock pool initialization.
Diffs
-----
src/account/LMI_AccountProvider.c 5805f5e9637a77585c3eb63e75f8ae2bdfbbf063
Diff: http://reviewboard-openlmi.rhcloud.com/r/874/diff/
Testing
-------
Thanks,
Robin Hack
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1168/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
software: fix querying repository database
Do not presume that any cache is available before call to yum.
If the cache is not there, call fails.
Diffs
-----
src/software/test/repository.py 129335412707d3c4c24afd1f84740b008827eb54
Diff: http://reviewboard-openlmi.rhcloud.com/r/1168/diff/
Testing
-------
Thanks,
Michal Minar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1169/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
software: test improvements
Do not use packages related to openlmi and CIM for testing purposes.
Diffs
-----
src/software/test/rpmcache.py c6205d2bf24a685da91f8ca2e35362882c39d5f5
Diff: http://reviewboard-openlmi.rhcloud.com/r/1169/diff/
Testing
-------
Thanks,
Michal Minar