-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1281/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Updates to software provider test
Diffs
-----
src/software/test/lmi-test.repo PRE-CREATION
src/software/test/testSoftware.py PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1281/diff/
Testing
-------
Thanks,
Jan Grec
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1147/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
software - tests: software test suite with basic tests
This is only a "current-status" review. I'll be very thankful for any comments on what's wrong, how the structure should look like, etc.
My TODO is to
* repair all broken tests
* add all tests mentioned
* bind test suite with new LmiTestCase class
I apologize for inconvenience, but I wasn't able to save previous review notes.
Diffs
-----
src/software/test/lmi-test.repo PRE-CREATION
src/software/test/testSoftware.py PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1147/diff/
Testing
-------
Thanks,
Jan Grec
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1571/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
-------
Explicitly add LVM devices to list of blivet devices.
Blivet doesn't contain VGs or LVs anymore. Work around that issue.
Diffs
-----
src/lmi/storage/util/storage.py ff6da1be1eaf2c0098bb465ac711d1e8454dc77a
Diff: http://reviewboard-openlmi.rhcloud.com/r/1571/diff/
Testing
-------
Thanks,
Jan Synacek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1506/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description
-------
When creating new LMIInstanceName via LMIClass.new_instance_name(), all the string key-bindings are converted into unicode strings.
Similar operations are performed, when assigning a new value to LMIInstanceNames' key-binding and LMIInstances' property.
Diffs
-----
cli/lmi/shell/LMIClass.py 67c21c1a4431d2b98faa04a6281c27012632e478
cli/lmi/shell/LMIInstanceName.py 01b0e332b65e459477f2e02fadba3e3f725161ad
cli/lmi/shell/LMIUtil.py 69cbf75fdf73d57d3b6e5067edf72100962b6df7
Diff: http://reviewboard-openlmi.rhcloud.com/r/1506/diff/
Testing
-------
Thanks,
Peter Hatina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1339/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description
-------
LMIIndicationListener.add_handler() appends 16 more random characters at the end of handler name. The patch fixes the requested unique string.
Diffs
-----
cli/lmi/shell/LMIIndicationListener.py 4f70e7720e859922a0a4ed57f872d5bafb7c724b
Diff: http://reviewboard-openlmi.rhcloud.com/r/1339/diff/
Testing
-------
Thanks,
Peter Hatina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1329/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description
-------
The patch breaks a compulsory call order of start() -> is_alive()/stop() within LMIIndicationListener objects.
Diffs
-----
cli/lmi/shell/LMIIndicationListener.py 1ec2f21c21291153289e8184026be7c69b27d504
Diff: http://reviewboard-openlmi.rhcloud.com/r/1329/diff/
Testing
-------
Thanks,
Peter Hatina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1512/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
This patch solves:
* Avoid race conditions with shadow-utils.
* Avoid race condition with libuser: uid/gid "sharing" amoung users/groups.
* Fix deadlock in lock.c code.
This patch introduces giant lock which is held for all write operations.
Diffs
-----
src/account/LMI_AccountManagementServiceProvider.c d4e51d55e259c582c4e145fcd45191aec6e484b1
src/account/LMI_AccountProvider.c fa2e3165f79844d4fac908ce344a69d735f6150d
src/account/LMI_GroupProvider.c efdbad53c57c102a9c6e760da968773e9aa2bf60
src/account/lock.h ab5827bb543ad35e4ab25e7e3edc84f5c416e1fc
src/account/lock.c b18b87dd11c42923699d53e409460aeb7b4a996a
Diff: http://reviewboard-openlmi.rhcloud.com/r/1512/diff/
Testing
-------
Thanks,
Robin Hack
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1647/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
This is an attempt to include profile (un)registration within the
(un)register-PROVIDER make target. This commit extends the cim_registration
macro by an extra argument of the profile file. However it is currently
limited to a single argument.
Diffs
-----
cmake/modules/OpenLMIMacros.cmake d55f983d2589bb3bee1a14668275b2ed96142cfa
src/account/CMakeLists.txt 83ca474a00a3a8a514bed4fc787360563ad56d01
src/fan/CMakeLists.txt 446e38b820ad53ae28b619df538c49f03a33bb69
src/hardware/CMakeLists.txt 29b63d342039a2e19a1fcdfe626cfab2b3a3002f
src/journald/CMakeLists.txt 1e6f19372172e5410f7b902ab5f61cac262fdf69
src/logicalfile/CMakeLists.txt 3a09a4ad7a545f8a74f73175461943516e3f8fde
src/power/CMakeLists.txt 44b2109ec5ce0c41c6d7091144bd58c0a86e84a2
src/realmd/CMakeLists.txt dbf2e5463d9192d6dc1dbf767c7be1242e67eb11
src/service-dbus/CMakeLists.txt 4ba32316993c78ec6ae41287fc97867e23fcf098
src/service/CMakeLists.txt 6d75d38247a8c06b8f6b5e5f4d3b1f8615c910d9
src/software-dbus/CMakeLists.txt 5202c33e302bca4b1a48f71bcdf884ff4e1ba01e
Diff: http://reviewboard-openlmi.rhcloud.com/r/1647/diff/
Testing
-------
Thanks,
Tomáš Bžatek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1559/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Summary (updated)
-----------------
Add tests for invalid system files
Repository: openlmi-providers
Description (updated)
-------
account: Add tests for invalid system files
Each test creates an instance it LMI_Account, then intentionally
cripples one of system files related to users/groups, and performs
a simple sanity test that checks if instance properties are readable.
Diffs (updated)
-----
src/account/test/TestAccountInvalidEtc.py PRE-CREATION
src/account/test/common.py 2b3b423e125dad81dc8ed3385be15ebc4f785228
src/account/test/generate_cases.py PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1559/diff/
Testing
-------
Thanks,
Alois Mahdal