This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1771/

On červen 13th, 2014, 10:59 dop. UTC, Jan Synacek wrote:

src/libs/libopenlmi/openlmi-utils.h (Diff revision 2)
1
#ifndef COMMON_H

My guess is that this guard is pretty... common. It may be safer to rename it or prefix it or something. Not an issue, though.

Good catch!


On červen 13th, 2014, 10:59 dop. UTC, Jan Synacek wrote:

src/libs/libopenlmi/openlmi-utils.c (Diff revision 2)
24
    int len = strlen(key);

Strlen of a void pointer looks weird. Maybe explicitely type key to const gchar or something like that? I'd say that the compiler should warn about this.

Fixed.


- Michal


On červen 17th, 2014, 6:40 dop. UTC, Michal Minar wrote:

Review request for OpenLMI Developers.
By Michal Minar.

Updated Čer. 17, 2014, 6:40 dop.

Repository: openlmi-providers

Description

added openlmi-utils to openlmicommon library

Diffs

  • src/libs/libopenlmi/openlmi-utils.c (PRE-CREATION)
  • src/libs/libopenlmi/CMakeLists.txt (867260ebdc3693b205044a0271d8c1e1bd74b59d)
  • src/libs/libopenlmi/openlmi-utils.h (PRE-CREATION)

View Diff