Review Request 1147: [1/1] software - tests: software test suite with basic tests
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1147/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
software - tests: software test suite with basic tests
This is only a "current-status" review. I'll be very thankful for any comments on what's wrong, how the structure should look like, etc.
My TODO is to
* repair all broken tests
* add all tests mentioned
* bind test suite with new LmiTestCase class
I apologize for inconvenience, but I wasn't able to save previous review notes.
Diffs
-----
src/software/test/lmi-test.repo PRE-CREATION
src/software/test/testSoftware.py PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1147/diff/
Testing
-------
Thanks,
Jan Grec
8 years, 10 months
Review Request 430: openlmi-locale [1/1] New provider: Locale
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/430/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
New provider: Locale
Diffs
-----
CMakeLists.txt c5a5c7c8fd1b24f76c4953e8a3cc8257bbe58d8e
README a80a1d2624c80367ed53e06f50804ed39b3103da
mof/60_LMI_Locale.mof PRE-CREATION
openlmi-providers.spec 6e75e6f8332df807be4c2c5260211fce3339db89
src/CMakeLists.txt 27bd416e1545725af0975e806975ca2119b4388b
src/locale/CMakeLists.txt PRE-CREATION
src/locale/LMI_LocaleProvider.c PRE-CREATION
src/locale/localed.h PRE-CREATION
src/locale/localed.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/430/diff/
Testing
-------
Thanks,
Vitezslav Crhonek
9 years, 3 months
Re: Review Request 314: [openlmi-storage] Add .reviewboardrc configuration file
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/314/
-----------------------------------------------------------
(Updated July 3, 2013, 12:03 p.m.)
Status
------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
-------
Add .reviewboardrc configuration file
Also removes the overly-agressive .* entry in .gitignore, since it prevents updates to the .gitignore and .reviewboardrc files.
Diffs
-----
.gitignore 5c8cb4947de0a5845db267b5490de2bd29f4b35f
.reviewboardrc PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/314/diff/
Testing
-------
Submitted this review via post-review using this configuration file.
Thanks,
Stephen Gallagher
9 years, 8 months
Review Request 1285: Define OpenLMI 1.0.0
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1285/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Define OpenLMI 1.0.0
Set strict version dependencies for the meta-package
Diffs
-----
openlmi-providers.spec aa2225fcac396ac49ffad95c99a9241e5825dda1
Diff: http://reviewboard-openlmi.rhcloud.com/r/1285/diff/
Testing
-------
Built the package, verified that the resulting openlmi meta-package has:
openlmi-account = 0.4.1-3.fc21
openlmi-hardware = 0.4.1-3.fc21
openlmi-networking = 0.2.1
openlmi-powermanagement = 0.4.1-3.fc21
openlmi-providers = 1.0.0-3.fc21
openlmi-service = 0.4.1-3.fc21
openlmi-software = 0.4.1-3.fc21
openlmi-storage = 0.7.0
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
tog-pegasus
rpmlib(PayloadIsXz) <= 5.2-1
Thanks,
Stephen Gallagher
9 years, 9 months
Review Request 1289: [1/1] Service: Support indications on instance property modification.
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1289/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Service: Support indications on instance property modification.
Diffs
-----
mof/60_LMI_Service.mof 1a86fec8462402d5f5b5ff4f2661596dca470433
src/service-dbus/CMakeLists.txt 3cc2082ac2b28660b854c5e81a3eb581bac8efb5
src/service-dbus/LMI_ServiceInstanceModificationIndicationProvider.c PRE-CREATION
src/service-dbus/util/serviceutil.h fbdadad5be2d37920407783d806d36af476d62cb
src/service-dbus/util/serviceutil.c 50b18b91cd3083a821a6a3be5f682aafc509be3d
Diff: http://reviewboard-openlmi.rhcloud.com/r/1289/diff/
Testing
-------
Thanks,
Vitezslav Crhonek
9 years, 9 months
Review Request 1314: providers [4/4] software: minor test enhancements
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1314/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
software: minor test enhancements
Added one test to SoftwareIdentityFileCheck.Invoke() method testing
correct error code.
Renamed testing package pkg1 to pkg2 in misc repository to match its
comment.
Rendering function CIMInstanceNames should behave nicely for
objects of another type and return their text representation.
Diffs
-----
src/python/lmi/test/base.py 15229797c48c8ab14b57a381b38899ae05ff20fe
src/software/test/reposetup.py 93f442968d8c074e950a70e89b14c9a0178d7337
src/software/test/repository.py d963d4347783efca56f3267ab59810d838c01baf
src/software/test/test_installed_software_identity.py 3535294fd495e97b3c76631c01f9b17f7b708722
src/software/test/test_software_identity_file_check.py 478307605a2cb142bbe6b1433c3bdc6b89352e39
src/software/test/test_software_installation_service_affects_element.py 0ac15142c5ac9eb13189e0751e815f543c51a500
src/software/test/util.py 3c63be0d9cb274aa8a3b7659a234195de61236ec
Diff: http://reviewboard-openlmi.rhcloud.com/r/1314/diff/
Testing
-------
Thanks,
Michal Minar
9 years, 9 months