On Čer. 10, 2014, 8:43 dop., Tomáš Bžatek wrote:
> src/libs/libopenlmi/openlmi-utils.h, line 9
>
<
http://reviewboard-openlmi.rhcloud.com/r/1771/diff/1/?file=10072#file1007...
>
> This is more a recommendation: please do not mix namespaces, i.e. g_* belongs to
glib, similar to gtk_*. It's an unwritten rule from the past experience, when
functions with same names have been introduced later, causing build failures.
>
> In this case with such complicated names, it's highly unlikely though.
I see. No problem. Changed to 'lmi_'.
On Čer. 10, 2014, 8:43 dop., Tomáš Bžatek wrote:
> src/libs/libopenlmi/openlmi-utils.c, line 29
>
<
http://reviewboard-openlmi.rhcloud.com/r/1771/diff/1/?file=10073#file1007...
>
> Hint: if you don't mind extra memory (de-)allocation, have a look at
g_ascii_strdown()
Thanks for a tip. I'd rather stick to this dumb variant without any error handling.
- Michal
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1771/#review2702
-----------------------------------------------------------
On Čer. 10, 2014, 9:06 dop., Michal Minar wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1771/
-----------------------------------------------------------
(Updated Čer. 10, 2014, 9:06 dop.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
added openlmi-utils to openlmicommon library
Diffs
-----
src/libs/libopenlmi/openlmi-utils.c PRE-CREATION
src/libs/libopenlmi/CMakeLists.txt 867260ebdc3693b205044a0271d8c1e1bd74b59d
src/libs/libopenlmi/openlmi-utils.h PRE-CREATION
Diff:
http://reviewboard-openlmi.rhcloud.com/r/1771/diff/
Testing
-------
Thanks,
Michal Minar