-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1891/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Add lmipolkitagent
See lmipolkitagent.c for documentation of its purpose.
All the forks and execs were carefuly placed, don't change them without
extensive testing! These parts are hard to debug...
FindPAM.cmake is taken from kde-workspace-4.11.10.tar.xz
Diffs
-----
CMakeLists.txt f2900abec0ba4b54fed481b7d1390eaed2ba1593
cmake/modules/FindPAM.cmake PRE-CREATION
src/CMakeLists.txt 0b8a8ff29c7a0c6af4ee2ba0025578c0659f3aa3
src/tools/CMakeLists.txt PRE-CREATION
src/tools/lmipolkitagent.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1891/diff/
Testing
-------
Thanks,
Jan Safranek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1892/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Add the polkit stuff to .spec file
Diffs
-----
openlmi-providers.spec b5a5eddf72f5bd76b030ab62c9e73ddc802d1d57
Diff: http://reviewboard-openlmi.rhcloud.com/r/1892/diff/
Testing
-------
Thanks,
Jan Safranek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1909/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Add 'interactive' argument to DBus calls.
We need polkit to ask for password.
Diffs
-----
CMakeLists.txt f2900abec0ba4b54fed481b7d1390eaed2ba1593
src/locale/LMI_LocaleProvider.c c744c9d4e226f208d985b029e4dffd4d4b4d2264
src/locale/localed.h daf4274972715d771356a199dd7e3a51227b941e
src/locale/localed.c 51bd3e3919578f3780b86dca5dc8da3eecbdf00e
Diff: http://reviewboard-openlmi.rhcloud.com/r/1909/diff/
Testing
-------
Thanks,
Jan Safranek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1923/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Add -a option to lmipolkitagent.
Storage provider runs only as root, getting remote user name in every request
from the CIMOM and doing it's own authorization.
For that purpose, it needs the lmipolkitagent to:
- start a PAM session (for any user, root is fine)
- authenticate *any* requests from polkit
- authentication has been done on CIMOM level
Diffs
-----
src/tools/lmipolkitagent.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1923/diff/
Testing
-------
Thanks,
Jan Safranek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1931/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Use polkit for the providers, which can use it.
Diffs
-----
openlmi-providers.spec 9a21585aef2655083d1bbe147137f7ad925539e2
src/journald/cmpiLMI_Journald-cimprovagt 0e8e0f0390d184943c5d6c3255d6a356e43c1aca
src/locale/cmpiLMI_Locale-cimprovagt 1f1de47d276aa1a13f0897d287bea3dafb9c7270
src/logicalfile/cmpiLMI_LogicalFile-cimprovagt 1f1de47d276aa1a13f0897d287bea3dafb9c7270
src/power/cmpiLMI_PowerManagement-cimprovagt 3f9c577c60a27015f122e61bd51b17d28693e0fa
src/realmd/cmpiLMI_Realmd-cimprovagt 1f1de47d276aa1a13f0897d287bea3dafb9c7270
src/software-dbus/cmpiLMI_Software-cimprovagt 51d0c99bf688dfb0117c94ee7d5e2f2d23ab5bc4
src/sssd/cmpiLMI_SSSD-cimprovagt 1f1de47d276aa1a13f0897d287bea3dafb9c7270
Diff: http://reviewboard-openlmi.rhcloud.com/r/1931/diff/
Testing
-------
Thanks,
Jan Safranek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1924/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
-------
Add polkit integration.
The polkit actions are taken from storaged and udisks, just with
org.openlmi.storage prefix. This allows us to experiment with existing
authorization schemes and identify problems in storaged and udisks.
The storage provider itself still runs as root, but is asks polkit
to authorize each action. Since polkit authorizes processes and not
users, we must spawn a little helper process under UID of the remote user
to check the authorization, see lmi.storage.util.polkit module. There is one
fork and several execs involved in each policy check.
Diffs
-----
MANIFEST.in 6b6d42c5adb2ab59c8c9562029508ff6498392f6
openlmi-storage.spec a9226e01cfe6530cf40f9efe0629703c01a4144f
org.openlmi.storage.policy PRE-CREATION
pycmpiLMI_Storage-cimprovagt 267447e284c78821be5f8a95fefa6b547e0e8044
src/lmi/storage/LMI_DiskPartitioningConfigurationService.py 9417d2abe012d7ad46e603d5f9dc00c98e3a9b56
src/lmi/storage/LMI_ExtentEncryptionConfigurationService.py cd8fd1b1f0bd2c8d5e466ee5679800dc39ad324d
src/lmi/storage/LMI_FileSystemConfigurationService.py f6e21cdacaea091519cda5a744973076ea36a158
src/lmi/storage/LMI_MountConfigurationService.py a08935d26d459bf97ef6cc115c392ae0bfe7e54d
src/lmi/storage/LMI_StorageConfigurationService.py bf98619646d768a831cb00bd0bd99ed2a607f816
src/lmi/storage/util/polkit.py PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1924/diff/
Testing
-------
Thanks,
Jan Safranek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1281/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Updates to software provider test
Diffs
-----
src/software/test/lmi-test.repo PRE-CREATION
src/software/test/testSoftware.py PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1281/diff/
Testing
-------
Thanks,
Jan Grec
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1147/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
software - tests: software test suite with basic tests
This is only a "current-status" review. I'll be very thankful for any comments on what's wrong, how the structure should look like, etc.
My TODO is to
* repair all broken tests
* add all tests mentioned
* bind test suite with new LmiTestCase class
I apologize for inconvenience, but I wasn't able to save previous review notes.
Diffs
-----
src/software/test/lmi-test.repo PRE-CREATION
src/software/test/testSoftware.py PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1147/diff/
Testing
-------
Thanks,
Jan Grec