-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1281/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Updates to software provider test
Diffs
-----
src/software/test/lmi-test.repo PRE-CREATION
src/software/test/testSoftware.py PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1281/diff/
Testing
-------
Thanks,
Jan Grec
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1147/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
software - tests: software test suite with basic tests
This is only a "current-status" review. I'll be very thankful for any comments on what's wrong, how the structure should look like, etc.
My TODO is to
* repair all broken tests
* add all tests mentioned
* bind test suite with new LmiTestCase class
I apologize for inconvenience, but I wasn't able to save previous review notes.
Diffs
-----
src/software/test/lmi-test.repo PRE-CREATION
src/software/test/testSoftware.py PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1147/diff/
Testing
-------
Thanks,
Jan Grec
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1571/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
-------
Explicitly add LVM devices to list of blivet devices.
Blivet doesn't contain VGs or LVs anymore. Work around that issue.
Diffs
-----
src/lmi/storage/util/storage.py ff6da1be1eaf2c0098bb465ac711d1e8454dc77a
Diff: http://reviewboard-openlmi.rhcloud.com/r/1571/diff/
Testing
-------
Thanks,
Jan Synacek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1699/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
This is the OpenLMI SSSD provider.
It is yet dependent on an unreleased version of SSSD and even on patches that are not present in SSSD master branch. We are slowly reviewing and push these patches to the master. In the mean time, please use the SSSD from my repository, branch #openlmi:
http://fedorapeople.org/cgit/pbrezina/public_git/sssd.git/log/?h=openlmi
The IFP service has to be enabled in SSSD for the provider to be able to communicate with the daemon.
Diffs
-----
CMakeLists.txt bcea09707d1d87db374cf6561d00a19258b54b3b
README 3466aee84a57e142256fd77188aa5c87ee3167f5
doc/admin/CMakeLists.txt 96e7616e2af807d99b4afe7af81571367e15f286
doc/admin/sssd/index.rst PRE-CREATION
mof/60_LMI_SSSD.mof PRE-CREATION
mof/CMakeLists.txt 0c020a18517ecc469c70a93a6b7b824e0bca3117
openlmi-providers.spec 624ba7711a0836f37143cb16187ff548a647328f
src/CMakeLists.txt e0fbb4e05236fc10164f359b5a13f6406aacbda1
src/sssd/90_LMI_SSSD_Profile.mof.skel PRE-CREATION
src/sssd/CMakeLists.txt PRE-CREATION
src/sssd/LMI_HostedSSSDServiceProvider.c PRE-CREATION
src/sssd/LMI_SSSDAvailableComponentProvider.c PRE-CREATION
src/sssd/LMI_SSSDAvailableDomainProvider.c PRE-CREATION
src/sssd/LMI_SSSDBackendDomainProvider.c PRE-CREATION
src/sssd/LMI_SSSDBackendProvider.c PRE-CREATION
src/sssd/LMI_SSSDBackendProviderProvider.c PRE-CREATION
src/sssd/LMI_SSSDComponentProvider.c PRE-CREATION
src/sssd/LMI_SSSDDomainProvider.c PRE-CREATION
src/sssd/LMI_SSSDDomainSubdomainProvider.c PRE-CREATION
src/sssd/LMI_SSSDMonitorProvider.c PRE-CREATION
src/sssd/LMI_SSSDProviderProvider.c PRE-CREATION
src/sssd/LMI_SSSDResponderProvider.c PRE-CREATION
src/sssd/LMI_SSSDServiceProvider.c PRE-CREATION
src/sssd/cmpiLMI_SSSD-cimprovagt PRE-CREATION
src/sssd/sssd_components.h PRE-CREATION
src/sssd/sssd_components.c PRE-CREATION
src/sssd/sssd_domains.h PRE-CREATION
src/sssd/sssd_domains.c PRE-CREATION
src/sssd/utils.h PRE-CREATION
src/sssd/utils.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1699/diff/
Testing
-------
Thanks,
Pavel Březina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1506/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description
-------
When creating new LMIInstanceName via LMIClass.new_instance_name(), all the string key-bindings are converted into unicode strings.
Similar operations are performed, when assigning a new value to LMIInstanceNames' key-binding and LMIInstances' property.
Diffs
-----
cli/lmi/shell/LMIClass.py 67c21c1a4431d2b98faa04a6281c27012632e478
cli/lmi/shell/LMIInstanceName.py 01b0e332b65e459477f2e02fadba3e3f725161ad
cli/lmi/shell/LMIUtil.py 69cbf75fdf73d57d3b6e5067edf72100962b6df7
Diff: http://reviewboard-openlmi.rhcloud.com/r/1506/diff/
Testing
-------
Thanks,
Peter Hatina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1339/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description
-------
LMIIndicationListener.add_handler() appends 16 more random characters at the end of handler name. The patch fixes the requested unique string.
Diffs
-----
cli/lmi/shell/LMIIndicationListener.py 4f70e7720e859922a0a4ed57f872d5bafb7c724b
Diff: http://reviewboard-openlmi.rhcloud.com/r/1339/diff/
Testing
-------
Thanks,
Peter Hatina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1329/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description
-------
The patch breaks a compulsory call order of start() -> is_alive()/stop() within LMIIndicationListener objects.
Diffs
-----
cli/lmi/shell/LMIIndicationListener.py 1ec2f21c21291153289e8184026be7c69b27d504
Diff: http://reviewboard-openlmi.rhcloud.com/r/1329/diff/
Testing
-------
Thanks,
Peter Hatina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1759/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Basic set of tests with focus on this flow:
1. add set of subscriptions
2. add set of handlers
3. trigger sequence of "interesting" events
4. collect indications
5. and make assertions as needed
Currently the assertions are mostly that correct classes have been
delivered, reporting the events in correct order.
~~
This is followup to request #1741.
Since then:
* Rewrote old and added missing docstrings
* `TestIndicationEventStream` now inherits from
`IndicationStreamTestCase` instead using it as mixin
* fixed typos
* removed unnecessary CLASS_NAME and NEEDS_INDICATIONS
* made `handlers` option explicit instead of using
`default_driver_args`
* fixed `xtest*` typos
Diffs
-----
src/account/test/TestIndicationEventStream.py PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1759/diff/
Testing
-------
Thanks,
Alois Mahdal