-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1281/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Updates to software provider test
Diffs
-----
src/software/test/lmi-test.repo PRE-CREATION
src/software/test/testSoftware.py PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1281/diff/
Testing
-------
Thanks,
Jan Grec
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1147/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
software - tests: software test suite with basic tests
This is only a "current-status" review. I'll be very thankful for any comments on what's wrong, how the structure should look like, etc.
My TODO is to
* repair all broken tests
* add all tests mentioned
* bind test suite with new LmiTestCase class
I apologize for inconvenience, but I wasn't able to save previous review notes.
Diffs
-----
src/software/test/lmi-test.repo PRE-CREATION
src/software/test/testSoftware.py PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1147/diff/
Testing
-------
Thanks,
Jan Grec
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1339/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description
-------
LMIIndicationListener.add_handler() appends 16 more random characters at the end of handler name. The patch fixes the requested unique string.
Diffs
-----
cli/lmi/shell/LMIIndicationListener.py 4f70e7720e859922a0a4ed57f872d5bafb7c724b
Diff: http://reviewboard-openlmi.rhcloud.com/r/1339/diff/
Testing
-------
Thanks,
Peter Hatina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1329/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description
-------
The patch breaks a compulsory call order of start() -> is_alive()/stop() within LMIIndicationListener objects.
Diffs
-----
cli/lmi/shell/LMIIndicationListener.py 1ec2f21c21291153289e8184026be7c69b27d504
Diff: http://reviewboard-openlmi.rhcloud.com/r/1329/diff/
Testing
-------
Thanks,
Peter Hatina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1333/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
-------
Make LMI_LVStorageExtent a common superclass.
This change is a preparation for thin provisioning support.
Diffs
-----
mof/70_LMI_Storage-Profiles.mof be68b2b1d1033618e505608ab49bd7a76b21b774
mof/LMI_Storage-BlockStorage.mof 0601e64fd026566637ddd73fc0bd245708d5b957
mof/LMI_Storage-MethodParameters.mof cd3cacff1ad2ff12e72d81f1406ca8ed03ccb95b
mof/LMI_Storage.reg 7a07f824b2c3e689f86a1dd6658d84e8f8c200e9
src/lmi/storage/LMI_LVStorageExtent.py c4f258121396807f60fe9e269a9f1ad59fd20113
src/lmi/storage/LMI_StorageConfigurationService.py a0ba2b1ac048575d1b3989a4d4336bd70fa5b389
src/lmi/storage/cimom_entry.py ea7783dc1b31def4f48126e6a3c0925c5bfad5fd
test/test_unused.py 96624b1eb1fe9738805437f3ecfae2b06710f0b7
Diff: http://reviewboard-openlmi.rhcloud.com/r/1333/diff/
Testing
-------
Basic testing via yawn.
Thanks,
Jan Synacek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/314/
-----------------------------------------------------------
(Updated July 3, 2013, 12:03 p.m.)
Status
------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
-------
Add .reviewboardrc configuration file
Also removes the overly-agressive .* entry in .gitignore, since it prevents updates to the .gitignore and .reviewboardrc files.
Diffs
-----
.gitignore 5c8cb4947de0a5845db267b5490de2bd29f4b35f
.reviewboardrc PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/314/diff/
Testing
-------
Submitted this review via post-review using this configuration file.
Thanks,
Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1379/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
service: Port tests to lmishell base
Diffs
-----
src/service-dbus/test/testService.py be12b4db3e252e356a42f85a45962aa943967f09
Diff: http://reviewboard-openlmi.rhcloud.com/r/1379/diff/
Testing
-------
Thanks,
Tomáš Bžatek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1388/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
-------
Add test to call all EnumerateInstance{s,Names}, GetInstance, Associators and References.
This is modification of
openlmi-providers/src/python/lmi/test/cases/test_lmi_instances.py from openlmi.
It creates some storage devices and then calls EnumerateInstances and
EnumerateInstanceNames on all LMI_* classes and then calls GetInstance,
AssociatorNames, Associators, ReferenceNames and References on all instances.
It just performs base sanity checks of the returned instances, like
EnumerateInstanceNames returns the same instances as EnumerateInstances.
Diffs
-----
test/lmishell/test_lmi_instances.py PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1388/diff/
Testing
-------
Thanks,
Jan Safranek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1404/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Let the test write to stderr.
Our test framework logs stderr and stdout separately and it's hard to match
them together.
Diffs
-----
src/python/lmi/test/cases/test_lmi_instances.py 65ecf98f46bc9f025a7e74c0a29d55ffbf59af71
Diff: http://reviewboard-openlmi.rhcloud.com/r/1404/diff/
Testing
-------
Thanks,
Jan Safranek