Review Request 1147: [1/1] software - tests: software test suite with basic tests
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1147/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
software - tests: software test suite with basic tests
This is only a "current-status" review. I'll be very thankful for any comments on what's wrong, how the structure should look like, etc.
My TODO is to
* repair all broken tests
* add all tests mentioned
* bind test suite with new LmiTestCase class
I apologize for inconvenience, but I wasn't able to save previous review notes.
Diffs
-----
src/software/test/lmi-test.repo PRE-CREATION
src/software/test/testSoftware.py PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1147/diff/
Testing
-------
Thanks,
Jan Grec
9 years, 4 months
Review Request 430: openlmi-locale [1/1] New provider: Locale
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/430/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
New provider: Locale
Diffs
-----
CMakeLists.txt c5a5c7c8fd1b24f76c4953e8a3cc8257bbe58d8e
README a80a1d2624c80367ed53e06f50804ed39b3103da
mof/60_LMI_Locale.mof PRE-CREATION
openlmi-providers.spec 6e75e6f8332df807be4c2c5260211fce3339db89
src/CMakeLists.txt 27bd416e1545725af0975e806975ca2119b4388b
src/locale/CMakeLists.txt PRE-CREATION
src/locale/LMI_LocaleProvider.c PRE-CREATION
src/locale/localed.h PRE-CREATION
src/locale/localed.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/430/diff/
Testing
-------
Thanks,
Vitezslav Crhonek
9 years, 9 months
Review Request 1333: [1/1] Make LMI_LVStorageExtent a common superclass.
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1333/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
-------
Make LMI_LVStorageExtent a common superclass.
This change is a preparation for thin provisioning support.
Diffs
-----
mof/70_LMI_Storage-Profiles.mof be68b2b1d1033618e505608ab49bd7a76b21b774
mof/LMI_Storage-BlockStorage.mof 0601e64fd026566637ddd73fc0bd245708d5b957
mof/LMI_Storage-MethodParameters.mof cd3cacff1ad2ff12e72d81f1406ca8ed03ccb95b
mof/LMI_Storage.reg 7a07f824b2c3e689f86a1dd6658d84e8f8c200e9
src/lmi/storage/LMI_LVStorageExtent.py c4f258121396807f60fe9e269a9f1ad59fd20113
src/lmi/storage/LMI_StorageConfigurationService.py a0ba2b1ac048575d1b3989a4d4336bd70fa5b389
src/lmi/storage/cimom_entry.py ea7783dc1b31def4f48126e6a3c0925c5bfad5fd
test/test_unused.py 96624b1eb1fe9738805437f3ecfae2b06710f0b7
Diff: http://reviewboard-openlmi.rhcloud.com/r/1333/diff/
Testing
-------
Basic testing via yawn.
Thanks,
Jan Synacek
10 years, 1 month
Re: Review Request 314: [openlmi-storage] Add .reviewboardrc configuration file
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/314/
-----------------------------------------------------------
(Updated July 3, 2013, 12:03 p.m.)
Status
------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
-------
Add .reviewboardrc configuration file
Also removes the overly-agressive .* entry in .gitignore, since it prevents updates to the .gitignore and .reviewboardrc files.
Diffs
-----
.gitignore 5c8cb4947de0a5845db267b5490de2bd29f4b35f
.reviewboardrc PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/314/diff/
Testing
-------
Submitted this review via post-review using this configuration file.
Thanks,
Stephen Gallagher
10 years, 2 months
Review Request 1388: Add test to call all EnumerateInstance{s, Names}, GetInstance, Associators and References.
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1388/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
-------
Add test to call all EnumerateInstance{s,Names}, GetInstance, Associators and References.
This is modification of
openlmi-providers/src/python/lmi/test/cases/test_lmi_instances.py from openlmi.
It creates some storage devices and then calls EnumerateInstances and
EnumerateInstanceNames on all LMI_* classes and then calls GetInstance,
AssociatorNames, Associators, ReferenceNames and References on all instances.
It just performs base sanity checks of the returned instances, like
EnumerateInstanceNames returns the same instances as EnumerateInstances.
Diffs
-----
test/lmishell/test_lmi_instances.py PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1388/diff/
Testing
-------
Thanks,
Jan Safranek
10 years, 2 months