-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1771/#review2720
-----------------------------------------------------------
src/libs/libopenlmi/openlmi-utils.h
<
http://reviewboard-openlmi.rhcloud.com/r/1771/#comment1509>
My guess is that this guard is pretty... common. It may be safer to rename it or
prefix it or something. Not an issue, though.
src/libs/libopenlmi/openlmi-utils.h
<
http://reviewboard-openlmi.rhcloud.com/r/1771/#comment1511>
I'd say that the "end of include guard:" part of that string is
superfluous.
src/libs/libopenlmi/openlmi-utils.c
<
http://reviewboard-openlmi.rhcloud.com/r/1771/#comment1510>
I still don't get why we're mixing stdbool and gboolean. I'd say stick to
one (gboolean?) and obliterate the rest.
src/libs/libopenlmi/openlmi-utils.c
<
http://reviewboard-openlmi.rhcloud.com/r/1771/#comment1512>
Strlen of a void pointer looks weird. Maybe explicitely type key to const gchar or
something like that? I'd say that the compiler should warn about this.
src/libs/libopenlmi/openlmi-utils.c
<
http://reviewboard-openlmi.rhcloud.com/r/1771/#comment1513>
Since we're using 4 spaces as a default indentation, I'd say that it should be
the same here as well.
src/libs/libopenlmi/openlmi-utils.c
<
http://reviewboard-openlmi.rhcloud.com/r/1771/#comment1514>
See above.
- Jan Synacek
On June 10, 2014, 11:06 a.m., Michal Minar wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1771/
-----------------------------------------------------------
(Updated June 10, 2014, 11:06 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
added openlmi-utils to openlmicommon library
Diffs
-----
src/libs/libopenlmi/openlmi-utils.c PRE-CREATION
src/libs/libopenlmi/CMakeLists.txt 867260ebdc3693b205044a0271d8c1e1bd74b59d
src/libs/libopenlmi/openlmi-utils.h PRE-CREATION
Diff:
http://reviewboard-openlmi.rhcloud.com/r/1771/diff/
Testing
-------
Thanks,
Michal Minar