-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1281/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Updates to software provider test
Diffs
-----
src/software/test/lmi-test.repo PRE-CREATION
src/software/test/testSoftware.py PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1281/diff/
Testing
-------
Thanks,
Jan Grec
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1147/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
software - tests: software test suite with basic tests
This is only a "current-status" review. I'll be very thankful for any comments on what's wrong, how the structure should look like, etc.
My TODO is to
* repair all broken tests
* add all tests mentioned
* bind test suite with new LmiTestCase class
I apologize for inconvenience, but I wasn't able to save previous review notes.
Diffs
-----
src/software/test/lmi-test.repo PRE-CREATION
src/software/test/testSoftware.py PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1147/diff/
Testing
-------
Thanks,
Jan Grec
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1506/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description
-------
When creating new LMIInstanceName via LMIClass.new_instance_name(), all the string key-bindings are converted into unicode strings.
Similar operations are performed, when assigning a new value to LMIInstanceNames' key-binding and LMIInstances' property.
Diffs
-----
cli/lmi/shell/LMIClass.py 67c21c1a4431d2b98faa04a6281c27012632e478
cli/lmi/shell/LMIInstanceName.py 01b0e332b65e459477f2e02fadba3e3f725161ad
cli/lmi/shell/LMIUtil.py 69cbf75fdf73d57d3b6e5067edf72100962b6df7
Diff: http://reviewboard-openlmi.rhcloud.com/r/1506/diff/
Testing
-------
Thanks,
Peter Hatina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1339/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description
-------
LMIIndicationListener.add_handler() appends 16 more random characters at the end of handler name. The patch fixes the requested unique string.
Diffs
-----
cli/lmi/shell/LMIIndicationListener.py 4f70e7720e859922a0a4ed57f872d5bafb7c724b
Diff: http://reviewboard-openlmi.rhcloud.com/r/1339/diff/
Testing
-------
Thanks,
Peter Hatina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1329/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description
-------
The patch breaks a compulsory call order of start() -> is_alive()/stop() within LMIIndicationListener objects.
Diffs
-----
cli/lmi/shell/LMIIndicationListener.py 1ec2f21c21291153289e8184026be7c69b27d504
Diff: http://reviewboard-openlmi.rhcloud.com/r/1329/diff/
Testing
-------
Thanks,
Peter Hatina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1480/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
fan: make the sprintf_chip_name() thread-safe
Resolves: rhbz#1031650
Diffs
-----
src/fan/fan.c 14239521bcaf0404f5fb332bf624a00468b1d478
Diff: http://reviewboard-openlmi.rhcloud.com/r/1480/diff/
Testing
-------
Thanks,
Michal Minar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1472/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description
-------
support having number as part of command argument
Original commit digest in openlmi-scripts repo:
0330ef79ae83163b743c64480abc95ab5e92e9f8
Diffs
-----
cli/lmi/scripts/common/command/endpoint.py ab6471fb4efcee3df8f2d322b6c9c9d07be9e070
cli/lmi/scripts/common/command/util.py 2209475f57cfd8704dff0cd141a0d9957e9ffda3
Diff: http://reviewboard-openlmi.rhcloud.com/r/1472/diff/
Testing
-------
Thanks,
Michal Minar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1471/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description
-------
exit interactive mode only when LmiTerminate is raised
Do not take into account the return value of executed command when
deciding whether to stop the shell. Terminate only when LmiTerminate is
raised.
Original commit digest in openlmi-scripts repo:
97fc31be422e833232679cfb27fbcfd4ae3fde5b
Diffs
-----
cli/lmi/scripts/_metacommand/interactive.py bc31bf12033c566f10ee581e62d5a5be4321f3ca
Diff: http://reviewboard-openlmi.rhcloud.com/r/1471/diff/
Testing
-------
Thanks,
Michal Minar