This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1771/ |
Apart from a minor namespace clash, it looks fine.
src/libs/libopenlmi/openlmi-utils.h (Diff revision 1) | |||
---|---|---|---|
9 | guint g_str_lcase_hash_func(gconstpointer key); |
This is more a recommendation: please do not mix namespaces, i.e. g_ belongs to glib, similar to gtk_. It's an unwritten rule from the past experience, when functions with same names have been introduced later, causing build failures.
In this case with such complicated names, it's highly unlikely though.
src/libs/libopenlmi/openlmi-utils.h (Diff revision 1) | |||
---|---|---|---|
26 | gpointer g_tree_peek_first(GTree* tree, gpointer *value); |
Related to the note above, this one could cause conflict. Please choose a different namespace, e.g. lmi_ or prepend with an underscore (--> _g_tree_peek_first).
src/libs/libopenlmi/openlmi-utils.c (Diff revision 1) | |||
---|---|---|---|
29 | tmp[i] = tolower(((char const *)key)[i]); |
Hint: if you don't mind extra memory (de-)allocation, have a look at g_ascii_strdown()
- Tomáš Bžatek
On červen 10th, 2014, 8:18 dop. UTC, Michal Minar wrote:
Review request for OpenLMI Developers.
By Michal Minar.
Updated Čer. 10, 2014, 8:18 dop.
Repository:
openlmi-providers
Description
Diffs
|