Review Request 1147: [1/1] software - tests: software test suite with basic tests
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1147/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
software - tests: software test suite with basic tests
This is only a "current-status" review. I'll be very thankful for any comments on what's wrong, how the structure should look like, etc.
My TODO is to
* repair all broken tests
* add all tests mentioned
* bind test suite with new LmiTestCase class
I apologize for inconvenience, but I wasn't able to save previous review notes.
Diffs
-----
src/software/test/lmi-test.repo PRE-CREATION
src/software/test/testSoftware.py PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1147/diff/
Testing
-------
Thanks,
Jan Grec
8 years, 10 months
Review Request 1506: lmishell, convert strings to unicode when working with LMIInstance(Name)s
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1506/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description
-------
When creating new LMIInstanceName via LMIClass.new_instance_name(), all the string key-bindings are converted into unicode strings.
Similar operations are performed, when assigning a new value to LMIInstanceNames' key-binding and LMIInstances' property.
Diffs
-----
cli/lmi/shell/LMIClass.py 67c21c1a4431d2b98faa04a6281c27012632e478
cli/lmi/shell/LMIInstanceName.py 01b0e332b65e459477f2e02fadba3e3f725161ad
cli/lmi/shell/LMIUtil.py 69cbf75fdf73d57d3b6e5067edf72100962b6df7
Diff: http://reviewboard-openlmi.rhcloud.com/r/1506/diff/
Testing
-------
Thanks,
Peter Hatina
9 years, 2 months
Review Request 430: openlmi-locale [1/1] New provider: Locale
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/430/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
New provider: Locale
Diffs
-----
CMakeLists.txt c5a5c7c8fd1b24f76c4953e8a3cc8257bbe58d8e
README a80a1d2624c80367ed53e06f50804ed39b3103da
mof/60_LMI_Locale.mof PRE-CREATION
openlmi-providers.spec 6e75e6f8332df807be4c2c5260211fce3339db89
src/CMakeLists.txt 27bd416e1545725af0975e806975ca2119b4388b
src/locale/CMakeLists.txt PRE-CREATION
src/locale/LMI_LocaleProvider.c PRE-CREATION
src/locale/localed.h PRE-CREATION
src/locale/localed.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/430/diff/
Testing
-------
Thanks,
Vitezslav Crhonek
9 years, 3 months
Review Request 1512: Account: Race conditions fixes (like: bz#1061150)
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1512/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
This patch solves:
* Avoid race conditions with shadow-utils.
* Avoid race condition with libuser: uid/gid "sharing" amoung users/groups.
* Fix deadlock in lock.c code.
This patch introduces giant lock which is held for all write operations.
Diffs
-----
src/account/LMI_AccountManagementServiceProvider.c d4e51d55e259c582c4e145fcd45191aec6e484b1
src/account/LMI_AccountProvider.c fa2e3165f79844d4fac908ce344a69d735f6150d
src/account/LMI_GroupProvider.c efdbad53c57c102a9c6e760da968773e9aa2bf60
src/account/lock.h ab5827bb543ad35e4ab25e7e3edc84f5c416e1fc
src/account/lock.c b18b87dd11c42923699d53e409460aeb7b4a996a
Diff: http://reviewboard-openlmi.rhcloud.com/r/1512/diff/
Testing
-------
Thanks,
Robin Hack
9 years, 4 months
Review Request 1528: Added tests for race conditions
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1528/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Added tests for race conditions. Based on bug 1061153, these tests attempt to create, modify or delete users from a number of threads. Tests clean up by reverting backup of /etc/passwd, /etc/groups, /etc/shadow and /etc/gshadow.
New classes are added that might be useful in future (maybe even elsewhere): BackupStorage to backup system files, Passwd to assess if /etc/passwd is corrupted.
Diffs
-----
src/account/test/TestAccountRaceConditions.py PRE-CREATION
src/account/test/common.py 1476d107a916e9ee47595e4bd39041445b9d8450
src/account/test/methods.py ffb9f7d9335e8082bba4ee65baa103a9651682a3
Diff: http://reviewboard-openlmi.rhcloud.com/r/1528/diff/
Testing
-------
Thanks,
Alois Mahdal
9 years, 4 months