Review Request 430: openlmi-locale [1/1] New provider: Locale
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/430/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
New provider: Locale
Diffs
-----
CMakeLists.txt c5a5c7c8fd1b24f76c4953e8a3cc8257bbe58d8e
README a80a1d2624c80367ed53e06f50804ed39b3103da
mof/60_LMI_Locale.mof PRE-CREATION
openlmi-providers.spec 6e75e6f8332df807be4c2c5260211fce3339db89
src/CMakeLists.txt 27bd416e1545725af0975e806975ca2119b4388b
src/locale/CMakeLists.txt PRE-CREATION
src/locale/LMI_LocaleProvider.c PRE-CREATION
src/locale/localed.h PRE-CREATION
src/locale/localed.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/430/diff/
Testing
-------
Thanks,
Vitezslav Crhonek
9 years, 9 months
Re: Review Request 314: [openlmi-storage] Add .reviewboardrc configuration file
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/314/
-----------------------------------------------------------
(Updated July 3, 2013, 12:03 p.m.)
Status
------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
-------
Add .reviewboardrc configuration file
Also removes the overly-agressive .* entry in .gitignore, since it prevents updates to the .gitignore and .reviewboardrc files.
Diffs
-----
.gitignore 5c8cb4947de0a5845db267b5490de2bd29f4b35f
.reviewboardrc PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/314/diff/
Testing
-------
Submitted this review via post-review using this configuration file.
Thanks,
Stephen Gallagher
10 years, 2 months
Review Request 875: journald: Support writing new records
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/875/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
journald: Support writing new records
This change adds ability to report new messages in the journal log.
This is done by the LMI_JournalLogRecord.CreateInstance() method call
taking only CreationClassName, LogCreationClassName, LogName and DataFormat
key properties as mandatory, with no need to specify the MessageTimestamp and
RecordID key properties. The returned instance will contain all the
information with actual RecordID key property of the new record.
As long as sd_journal_send() actually only queues the request, we need
to watch for journal changes in order to find the new record. This is
quite unfortunate as the daemon could be busy and we can't wait forever.
Messages are available immediately usually, a timeout is set to 5 seconds
for the moment.
Record matching is done by comparing the message itself, the origin function
name and PID. This brings sufficient amount of confidence though more
sophisticated approach may be needed in future to ensure fiull uniqueness.
Diffs
-----
src/journald/LMI_JournalLogRecordProvider.c PRE-CREATION
src/journald/instutil.h PRE-CREATION
src/journald/instutil.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/875/diff/
Testing
-------
Thanks,
Tomáš Bžatek
10 years, 5 months
Review Request 847: journald: Add iterator tests
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/847/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
journald: Add iterator tests
Tests basic iterator operations, assumes accessible journal and several (> 10)
records available.
Also comes with a simple example script for downloading complete journal.
--
This is the largest chunk of Python code I've ever written! \o/
Diffs
-----
src/journald/test/TestIterators.py PRE-CREATION
src/journald/test/list-journal PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/847/diff/
Testing
-------
Thanks,
Tomáš Bžatek
10 years, 5 months