Review Request 430: openlmi-locale [1/1] New provider: Locale
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/430/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
New provider: Locale
Diffs
-----
CMakeLists.txt c5a5c7c8fd1b24f76c4953e8a3cc8257bbe58d8e
README a80a1d2624c80367ed53e06f50804ed39b3103da
mof/60_LMI_Locale.mof PRE-CREATION
openlmi-providers.spec 6e75e6f8332df807be4c2c5260211fce3339db89
src/CMakeLists.txt 27bd416e1545725af0975e806975ca2119b4388b
src/locale/CMakeLists.txt PRE-CREATION
src/locale/LMI_LocaleProvider.c PRE-CREATION
src/locale/localed.h PRE-CREATION
src/locale/localed.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/430/diff/
Testing
-------
Thanks,
Vitezslav Crhonek
9 years, 9 months
Re: Review Request 314: [openlmi-storage] Add .reviewboardrc configuration file
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/314/
-----------------------------------------------------------
(Updated July 3, 2013, 12:03 p.m.)
Status
------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
-------
Add .reviewboardrc configuration file
Also removes the overly-agressive .* entry in .gitignore, since it prevents updates to the .gitignore and .reviewboardrc files.
Diffs
-----
.gitignore 5c8cb4947de0a5845db267b5490de2bd29f4b35f
.reviewboardrc PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/314/diff/
Testing
-------
Submitted this review via post-review using this configuration file.
Thanks,
Stephen Gallagher
10 years, 2 months
Review Request 568: lmishell, constant values
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/568/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description
-------
This patch introduces the access to contant values present either in the CIMClass or in the CIMMethod.
To access desired contant, do following (eg. storage provider):
> conf_class = c.root.cimv2.LMI_FileSystemConfigurationService
> conf_class.OperatingStatusValues.Completed
8
For quick list, just type following:
> conf_class.OperatingStatusValues
Dormant = 7
Immigrating = 11
Unknown = 0
Completed = 8
InService = 16
ShuttingDown = 13
InTest = 14
Stopping = 4
Stopped = 5
Servicing = 2
Aborted = 6
NotAvailable = 1
Snapshotting = 12
Transitioning = 15
Migrating = 9
Starting = 3
Emigrating = 10
>
Similar action can be performed within method:
> conf_service = conf_class.first_instance()
> conf_service.RequestStateChange.RequestedStateValues.Enabled
2
>
Diffs
-----
cli-tools/lmi/lmi_client_shell.py 8c25cece6c0782f77b47d1888f9f031691b27a4b
cli-tools/lmishell bbbe0df89844320c84c8445699046c656d058fd9
Diff: http://reviewboard-openlmi.rhcloud.com/r/568/diff/
Testing
-------
Thanks,
Peter Hatina
10 years, 6 months
Review Request 549: lmishell, synchro method calls
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/549/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description
-------
By this patch, we introduce a feature, which enables LMIShell to perform synchronous method calls. In other words, when there is a method call executed, which returns a CIM_ConcretJob object (derived from), LMIShell is able to either subscribe an indication and then wait for the job to finish and return job output parameters. If the shell is not able to use indications (can not start tcp server), then it uses "blind" polling as the waiting method. Indication method of waiting also checks the JobState value of the object to prevent the shell from infinite waiting.
To invoke a "synchro" method, see following (example with filesystem):
> ... some stuff to get necessary objects ...
> conf_service.SyncLMI_CreateFileSystem(FileSystemType = 11, InExtents = [sda1])
^^^^
The prefix "Sync" is also added to interactive interface (tab-completion).
Question 1)
As the patch of a version 1, there is only unsecure http used for indication delivery. The question is: what kind of certificate to use, do we generate some for the shell at install time, or use some existing? Please, tell me your opinion.
Question 2)
Can we setup Pegasus to permit other users to create objects in the namespace PG_InterOp? In the example below, there is root account used, other users for me with default Pegasus setup can not create indication handler and subscription objects. Now, the shell will fail to get necessary static filter instance (used for the subscription) and will fail to call "synchro" method.
Diffs
-----
cli-tools/lmi/__init__.py e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
cli-tools/lmi/lmi_client_shell.py 9a6788cc17582f7c4419df909cd4322d9e6b23f9
cli-tools/lmi/lmi_listener.py 6670b204a84485b6e1f8bef5dfa2893098f0a9da
cli-tools/lmishell a12233eedc159a6f6c570ca31dfff20ac6d17161
Diff: http://reviewboard-openlmi.rhcloud.com/r/549/diff/
Testing
-------
Tested with storage provider.
> c = connect("hostname", "root", "root")
> sda = c.root.cimv2.LMI_StorageExtent.first_instance({"ElementName" : "sda"})
> basedon = sda.first_reference(ResultClass = "LMI_PartitionBasedOn")
> sda1 = basedon.Dependent.to_instance()
> conf_service = c.root.cimv2.LMI_FileSystemConfigurationService.first_instance()
> (ret, out, err) = conf_service.SyncLMI_CreateFileSystem(FileSystemType = 11, InExtents = [sda1])
> print "%s\n%s\n%s" % (ret, out, err)
4096
NocaseDict({'out': _LmiInstance(classname='CIM_ManagedElement', ...)})
Note: see return value and output parameters (ret == 4096, out['out'] == _LmiInstance(...)) <- this will be changed once we have Pegasus fixed. Now synchro method does not modify return value of the method, therefore you can find 4096 in the result. Once we have proper values in output parameters (Job.JobOutParameters), return code and return parameters will be modified respectively.
Thanks,
Peter Hatina
10 years, 6 months
Review Request 583: [2/2] Add LUKS version 1.
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/583/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
-------
Add LUKS version 1.
Only LMI_LUKSFormat and LMI_ExtentEncryptionConfigurationService are
implemented. Howerever, these two classes add most of the LUKS
functionality. Setting and Capability classes were omitted.
Diffs
-----
mof/LMI_Storage-Luks.mof 3b7ba8e4fd000acdb1cf4232b8ec18120c4a5029
mof/LMI_Storage.reg cf690b166800bd3e4d15da506d86e60777215080
src/lmi/storage/LMI_ExtentEncryptionConfigurationService.py PRE-CREATION
src/lmi/storage/LMI_LUKSFormat.py PRE-CREATION
src/lmi/storage/cimom_entry.py a7c765244cd4fee2308a42c9147c15f1ff07a98f
Diff: http://reviewboard-openlmi.rhcloud.com/r/583/diff/
Testing
-------
Thanks,
Jan Synacek
10 years, 6 months
Review Request 660: Use lmi.providers for common classes.
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/660/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
-------
Use lmi.providers for common classes.
Diffs
-----
src/lmi/storage/BaseProvider.py e2f3275a5b115271a4b2360a1f926f948a94e400
src/lmi/storage/BasedOnProvider.py 8e7ec0c2a347c95beb140eac3b7ac9d8f5cdaeda
src/lmi/storage/CapabilitiesProvider.py 623af6cb6031ed6776fa9ccebe24c26a5fa2eaac
src/lmi/storage/DeviceProvider.py 276a5c67e5b35ee60b55f77e4c0332cc29792522
src/lmi/storage/ExtentProvider.py 8dfed605fdf938394612c2db2a76a3d0f0382364
src/lmi/storage/FormatProvider.py 3b857f69e6d07d30fab60efeb9a6079ed70d6585
src/lmi/storage/LMI_AttachedFileSystem.py d1a23731c3700c395027d1c89e90e12ac54a6e85
src/lmi/storage/LMI_BlockStorageStatisticalData.py ea1d796c97b5f2c0dbd152725f29a80e616feb3b
src/lmi/storage/LMI_DataFormatProvider.py c28f5a4184af706a41ddf3b8f2e49d77146975f9
src/lmi/storage/LMI_DiskPartition.py 2eeb55901c182249050ad0bc3cc6510693b29806
src/lmi/storage/LMI_DiskPartitionConfigurationCapabilities.py c1f3c337c4a2550c7d791459a6ee5db824fbe7a4
src/lmi/storage/LMI_DiskPartitionConfigurationSetting.py 0e278fec26ac922673cd74d8437cf46e1dff8d87
src/lmi/storage/LMI_DiskPartitioningConfigurationService.py b5d0f91f423b554b178e0177dfa2bcd074e42608
src/lmi/storage/LMI_FileSystemConfigurationCapabilities.py 3c89f44c376cf262f12042fa41ba7f1452fbf6bb
src/lmi/storage/LMI_FileSystemConfigurationService.py 9981c80bcca7123c1f8dd18359a65e8cea26efdb
src/lmi/storage/LMI_GenericDiskPartition.py 99eaac54d9ebfc2ad4813211ea51c7181dcd3769
src/lmi/storage/LMI_HostedFileSystem.py 2618fc248003891bf0a7efe36284978acda2278b
src/lmi/storage/LMI_HostedMount.py 00ac2879cb528416ace9af57dd8e73b3b14ae86b
src/lmi/storage/LMI_HostedStorageService.py 0aae25b548999714b01252061c232af9d81b3364
src/lmi/storage/LMI_InstalledPartitionTable.py 29cc63e38251dccadd83a7ed9de11994c9363e56
src/lmi/storage/LMI_LVAllocatedFromStoragePool.py b11a0022b3048e5dfa6e886dc67504dcbe6734c9
src/lmi/storage/LMI_LVBasedOn.py 61f2724c5ed1381023eb1dda07dd62faf504b57e
src/lmi/storage/LMI_LVStorageCapabilities.py f33bcd4de6e0c282b98ae9a60939b1de77c92a77
src/lmi/storage/LMI_LVStorageExtent.py c24cf7a7239f1140ca963035327c915225a79b93
src/lmi/storage/LMI_LocalFileSystem.py 40af763136057fb32e0d6c85f6b6e9883787600a
src/lmi/storage/LMI_MDRAIDBasedOn.py 7c9899c1e2ed89987e498fab2f005c571bfdd18b
src/lmi/storage/LMI_MDRAIDFormatProvider.py 82754a49a3e895efb2f0260a6f9a457dfa18041a
src/lmi/storage/LMI_MDRAIDStorageCapabilities.py 8dfe70251cd5a0ed9daea4f5b6ecc122a8d0b5f2
src/lmi/storage/LMI_MDRAIDStorageExtent.py 361a01cd00a3ce6a88e787568030e0d4174cec17
src/lmi/storage/LMI_MountConfigurationService.py 6433b11c6e272e9181bbb66d6fa6bbe0863965ff
src/lmi/storage/LMI_MountPoint.py 7292b8e8fca1ce8562542f787728d79fd4b11b8e
src/lmi/storage/LMI_MountedFileSystem.py 42220ba5aae9399d2e59fc5ec47de82ef2ea33de
src/lmi/storage/LMI_MountedFileSystemCapabilities.py 93e22de37ad3a01bd77680705938a293b36f0688
src/lmi/storage/LMI_PVFormatProvider.py 527c524c2c9c65b17a1075b32dfdc7fd5071efa0
src/lmi/storage/LMI_PartitionBasedOn.py 08fa47911228b7df89be33d682c0b7d1d5f5085a
src/lmi/storage/LMI_StorageConfigurationService.py 09084ddfb66d3d69121a6fffe529d9684f4ea913
src/lmi/storage/LMI_StorageExtent.py d97d180b18560f81fdb246e9d2077aae80810d16
src/lmi/storage/LMI_SystemStorageDevice.py c5340bc3925c7c281c9de00c484db0a3f0656f8e
src/lmi/storage/LMI_TransientFileSystem.py add46869aa30c83b66de2e621e18ef653c445d93
src/lmi/storage/LMI_VGAssociatedComponentExtent.py 0655a938be2c4c772cf55ebda263032f7ff2c1bd
src/lmi/storage/LMI_VGStorageCapabilities.py 8794124ef9818c682cb99b62c359d890e02b73ca
src/lmi/storage/LMI_VGStoragePool.py 0e35347908ce5f8afb025fad40ace0e2d59c2e3e
src/lmi/storage/LocalFileSystemProvider.py 45046bd5421507a19754bd7680385ffd171f2b82
src/lmi/storage/MountingProvider.py fdfa1f71618f9bc55d65d6d89a8df91af35e0ccf
src/lmi/storage/ProviderManager.py ca1dc938e87afab1884d46e058ea77d39792bcd2
src/lmi/storage/ServiceProvider.py 2f683877363c9f61bc3eb58bce998a6ac1aecf26
src/lmi/storage/SettingHelper.py 6dc3f306989e089538f5ac8bad2f951b31b64989
src/lmi/storage/SettingManager.py f7850551f4bbf32c5c16c89027f6e8bab44e479d
src/lmi/storage/SettingProvider.py eb2b38f3ec10ea1844d211cafbfefa10439a7e32
src/lmi/storage/StorageConfiguration.py 2839e58f5db23d8ba744ece4d1e930d4ca080774
src/lmi/storage/cimom_entry.py a7c765244cd4fee2308a42c9147c15f1ff07a98f
Diff: http://reviewboard-openlmi.rhcloud.com/r/660/diff/
Testing
-------
Thanks,
Jan Safranek
10 years, 7 months