-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/314/
-----------------------------------------------------------
(Updated July 3, 2013, 12:03 p.m.)
Status
------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
-------
Add .reviewboardrc configuration file
Also removes the overly-agressive .* entry in .gitignore, since it prevents updates to the .gitignore and .reviewboardrc files.
Diffs
-----
.gitignore 5c8cb4947de0a5845db267b5490de2bd29f4b35f
.reviewboardrc PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/314/diff/
Testing
-------
Submitted this review via post-review using this configuration file.
Thanks,
Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/549/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description
-------
By this patch, we introduce a feature, which enables LMIShell to perform synchronous method calls. In other words, when there is a method call executed, which returns a CIM_ConcretJob object (derived from), LMIShell is able to either subscribe an indication and then wait for the job to finish and return job output parameters. If the shell is not able to use indications (can not start tcp server), then it uses "blind" polling as the waiting method. Indication method of waiting also checks the JobState value of the object to prevent the shell from infinite waiting.
To invoke a "synchro" method, see following (example with filesystem):
> ... some stuff to get necessary objects ...
> conf_service.SyncLMI_CreateFileSystem(FileSystemType = 11, InExtents = [sda1])
^^^^
The prefix "Sync" is also added to interactive interface (tab-completion).
Question 1)
As the patch of a version 1, there is only unsecure http used for indication delivery. The question is: what kind of certificate to use, do we generate some for the shell at install time, or use some existing? Please, tell me your opinion.
Question 2)
Can we setup Pegasus to permit other users to create objects in the namespace PG_InterOp? In the example below, there is root account used, other users for me with default Pegasus setup can not create indication handler and subscription objects. Now, the shell will fail to get necessary static filter instance (used for the subscription) and will fail to call "synchro" method.
Diffs
-----
cli-tools/lmi/__init__.py e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
cli-tools/lmi/lmi_client_shell.py 9a6788cc17582f7c4419df909cd4322d9e6b23f9
cli-tools/lmi/lmi_listener.py 6670b204a84485b6e1f8bef5dfa2893098f0a9da
cli-tools/lmishell a12233eedc159a6f6c570ca31dfff20ac6d17161
Diff: http://reviewboard-openlmi.rhcloud.com/r/549/diff/
Testing
-------
Tested with storage provider.
> c = connect("hostname", "root", "root")
> sda = c.root.cimv2.LMI_StorageExtent.first_instance({"ElementName" : "sda"})
> basedon = sda.first_reference(ResultClass = "LMI_PartitionBasedOn")
> sda1 = basedon.Dependent.to_instance()
> conf_service = c.root.cimv2.LMI_FileSystemConfigurationService.first_instance()
> (ret, out, err) = conf_service.SyncLMI_CreateFileSystem(FileSystemType = 11, InExtents = [sda1])
> print "%s\n%s\n%s" % (ret, out, err)
4096
NocaseDict({'out': _LmiInstance(classname='CIM_ManagedElement', ...)})
Note: see return value and output parameters (ret == 4096, out['out'] == _LmiInstance(...)) <- this will be changed once we have Pegasus fixed. Now synchro method does not modify return value of the method, therefore you can find 4096 in the result. Once we have proper values in output parameters (Job.JobOutParameters), return code and return parameters will be modified respectively.
Thanks,
Peter Hatina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/583/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
-------
Add LUKS version 1.
Only LMI_LUKSFormat and LMI_ExtentEncryptionConfigurationService are
implemented. Howerever, these two classes add most of the LUKS
functionality. Setting and Capability classes were omitted.
Diffs
-----
mof/LMI_Storage-Luks.mof 3b7ba8e4fd000acdb1cf4232b8ec18120c4a5029
mof/LMI_Storage.reg cf690b166800bd3e4d15da506d86e60777215080
src/lmi/storage/LMI_ExtentEncryptionConfigurationService.py PRE-CREATION
src/lmi/storage/LMI_LUKSFormat.py PRE-CREATION
src/lmi/storage/cimom_entry.py a7c765244cd4fee2308a42c9147c15f1ff07a98f
Diff: http://reviewboard-openlmi.rhcloud.com/r/583/diff/
Testing
-------
Thanks,
Jan Synacek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/656/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
-------
Fixed truncation of partition sizes.
The size was to megabytes and it was not possible to create partitions
smaller than 1 MB.
Diffs
-----
src/lmi/storage/LMI_DiskPartitioningConfigurationService.py b5d0f91f423b554b178e0177dfa2bcd074e42608
Diff: http://reviewboard-openlmi.rhcloud.com/r/656/diff/
Testing
-------
Thanks,
Jan Safranek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/659/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
spec file updated to split python package
openlmi-python subpackage no longer exists
openlmi-python-base and openlmi-python-providers made instead
Diffs
-----
openlmi-providers.spec 168d7eae09f0710e4b85e52a1f6923ac9ed2cd44
Diff: http://reviewboard-openlmi.rhcloud.com/r/659/diff/
Testing
-------
Thanks,
Michal Minar