This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1771/ |
On červen 10th, 2014, 8:43 dop. UTC, Tomáš Bžatek wrote:
src/libs/libopenlmi/openlmi-utils.h (Diff revision 1) 9 guint g_str_lcase_hash_func(gconstpointer key);This is more a recommendation: please do not mix namespaces, i.e. g_ belongs to glib, similar to gtk_. It's an unwritten rule from the past experience, when functions with same names have been introduced later, causing build failures.
In this case with such complicated names, it's highly unlikely though.
I see. No problem. Changed to 'lmi_'.
On červen 10th, 2014, 8:43 dop. UTC, Tomáš Bžatek wrote:
src/libs/libopenlmi/openlmi-utils.c (Diff revision 1) 29 tmp[i] = tolower(((char const *)key)[i]);Hint: if you don't mind extra memory (de-)allocation, have a look at g_ascii_strdown()
Thanks for a tip. I'd rather stick to this dumb variant without any error handling.
- Michal
On červen 10th, 2014, 9:06 dop. UTC, Michal Minar wrote:
Review request for OpenLMI Developers.
By Michal Minar.
Updated Čer. 10, 2014, 9:06 dop.
Repository:
openlmi-providers
Description
Diffs
|