openlmi-reviews May 2013

openlmi-reviews@lists.fedorahosted.org

1 participants
16 discussions

Review Request 426: Account [1/1] Account: Use asprintf instead of snprintf
by Stephen Gallagher 12 Jun '13

12 Jun '13

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/426/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- Account: Use asprintf instead of snprintf Signed-off-by: Roman Rakus <rrakus(a)redhat.com> Diffs ----- src/account/LMI_AccountManagementServiceProvider.c 1af6cf4f55f574d3bf665202ff7b55224a8d9009 src/account/LMI_AccountProvider.c 27be7e15f706b681cf07f83cec56fef2ccc7ecf5 src/account/LMI_AssignedAccountIdentityProvider.c 323a582217cd1c101863cc489b3e4ee94aa3a4ff src/account/LMI_AssignedGroupIdentityProvider.c a9037f1bd86a39ef21869796a692a0ec85affb08 src/account/LMI_GroupProvider.c a9c547724ecf8e66f92efb1677ee3b6f348f6051 src/account/LMI_IdentityProvider.c 92c2b0119a3dd81ca62be99c6e09f894f46841cd src/account/LMI_MemberOfGroupProvider.c dddd2e80952d7a1bedc0a0291ada56b5d7a1aea9 src/account/LMI_ServiceAffectsIdentityProvider.c 64e218b4068c696dbb5479d7e73c2f38b4fc0cb5 Diff: http://reviewboard-openlmi.rhcloud.com/r/426/diff/ Testing ------- Thanks, Roman Rakus

1 4

Review Request 425: Hardware: Connect processor(s) and memory with chassis
by Stephen Gallagher 03 Jun '13

03 Jun '13

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/425/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- Hardware: Connect processor(s) and memory with chassis New providers: * LMI_ProcessorChipContainer * LMI_MemorySlot * LMI_MemorySlotContainer * LMI_MemoryPhysicalPackage * LMI_MemoryPhysicalPackageInConnector * LMI_PhysicalMemoryContainer This commit brings also provider for memory slot, and memory physical package, which is plugged in memory slot. Diffs ----- mof/60_LMI_Hardware.mof fe227da17ffa1a001b91e8e7eac14cbe9c7bb350 src/hardware/LMI_BaseboardContainerProvider.c 8a9aca15f4c0ca684a3c3936a5e2c83eb3c9ee83 src/hardware/LMI_Hardware.h 0c0714c0e430ac39be906a4f1e1a91c68e069f36 src/hardware/LMI_MemoryPhysicalPackageInConnectorProvider.c PRE-CREATION src/hardware/LMI_MemoryPhysicalPackageProvider.c PRE-CREATION src/hardware/LMI_MemorySlotContainerProvider.c PRE-CREATION src/hardware/LMI_MemorySlotProvider.c PRE-CREATION src/hardware/LMI_PhysicalMemoryContainerProvider.c PRE-CREATION src/hardware/LMI_ProcessorChipContainerProvider.c PRE-CREATION src/hardware/LMI_ProcessorProvider.c b8a30a6b1960f2b8aa8f822e8e91b2a38ef99988 src/hardware/dmidecode.h 140f492912cd5d662bbd56751b992326e1da19a0 src/hardware/dmidecode.c ab3b3599a9cff9cd304348ee95bd03e7d404579e Diff: http://reviewboard-openlmi.rhcloud.com/r/425/diff/ Testing ------- Thanks, Peter Schiffer

1 2

Review Request 427: Account [1/1] Account: Properly create/delete homedirs
by Stephen Gallagher 03 Jun '13

03 Jun '13

1 2

Re: Review Request 417: Account [1/1] Account: Correctly handle empty fields in shadow file
by Stephen Gallagher 31 May '13

31 May '13

1 2

Review Request 424: openlmi-networking [1/1] Fix syntax error in mof file
by Stephen Gallagher 30 May '13

30 May '13

1 2

Re: Review Request 423: [1/1] Add mounting documentation for admins.
by Stephen Gallagher 30 May '13

30 May '13

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/423/ ----------------------------------------------------------- (Updated May 30, 2013, 11:14 a.m.) Status ------ This change has been marked as submitted. Review request for OpenLMI Developers. Repository: openlmi-storage Description ------- Add mounting documentation for admins. Diffs ----- doc/admin/Makefile 630076a43c797d4ce70e50f48a9e7dc75a147bbb doc/admin/mof/Makefile 3d06e26c7eb58c2285b412975b0451409c130b86 doc/admin/pic/mounting-instance-2.uml PRE-CREATION doc/admin/pic/mounting-instance-3.uml PRE-CREATION doc/admin/pic/mounting-instance.uml PRE-CREATION doc/admin/usage-mounting.rst PRE-CREATION doc/admin/usage.rst 7d9df4ef87df9a9865d510a568a369e6eb7157fd Diff: http://reviewboard-openlmi.rhcloud.com/r/423/diff/ Testing ------- Thanks, Jan Synacek

1 0

Re: Review Request 423: [1/1] Add mounting documentation for admins.
by Stephen Gallagher 30 May '13

30 May '13

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/423/#review500 ----------------------------------------------------------- Ship it! doc/admin/usage-mounting.rst <http://reviewboard-openlmi.rhcloud.com/r/423/#comment303> typo: persistent - Jan Safranek On May 29, 2013, 3:35 p.m., Jan Synacek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard-openlmi.rhcloud.com/r/423/ > ----------------------------------------------------------- > > (Updated May 29, 2013, 3:35 p.m.) > > > Review request for OpenLMI Developers. > > > Repository: openlmi-storage > > > Description > ------- > > Add mounting documentation for admins. > > > Diffs > ----- > > doc/admin/Makefile 630076a43c797d4ce70e50f48a9e7dc75a147bbb > doc/admin/mof/Makefile 3d06e26c7eb58c2285b412975b0451409c130b86 > doc/admin/pic/mounting-instance-2.uml PRE-CREATION > doc/admin/pic/mounting-instance-3.uml PRE-CREATION > doc/admin/pic/mounting-instance.uml PRE-CREATION > doc/admin/usage-mounting.rst PRE-CREATION > doc/admin/usage.rst 7d9df4ef87df9a9865d510a568a369e6eb7157fd > > Diff: http://reviewboard-openlmi.rhcloud.com/r/423/diff/ > > > Testing > ------- > > > Thanks, > > Jan Synacek > >

1 1

Re: Review Request 421: openlmi-networking [4/4] Fix documentation to use new settings API
by Stephen Gallagher 30 May '13

30 May '13

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/421/ ----------------------------------------------------------- (Updated May 30, 2013, 10:03 a.m.) Status ------ This change has been marked as submitted. Review request for OpenLMI Developers. Repository: openlmi-networking Description ------- Fix documentation to use new settings API Diffs ----- doc/admin/usage-generic.rst aa27e6edb3501f2b12d0235638381f365b2bdef0 Diff: http://reviewboard-openlmi.rhcloud.com/r/421/diff/ Testing ------- Thanks, Radek Novacek

1 0

Re: Review Request 420: openlmi-networking [3/4] Rename AddStaticIPRoute to LMI_AddStaticIPRoute
by Stephen Gallagher 30 May '13

30 May '13

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/420/ ----------------------------------------------------------- (Updated May 30, 2013, 10:03 a.m.) Status ------ This change has been marked as submitted. Review request for OpenLMI Developers. Repository: openlmi-networking Description ------- Rename AddStaticIPRoute to LMI_AddStaticIPRoute Add the LMI_ prefix to emphasize that it's a custom class. Diffs ----- mof/LMI_Networking.mof d03d6e1c06c5fe2f17711816ab29c1cef4e91c88 src/LMI_IPAssignmentSettingDataProvider.c 538123c0a45deace760eca742acda80028c0d8ae test/test_create_destroy_connection.py 39dc2bec3c3bc14bb8833fd9c888d8b3e8caa8a5 Diff: http://reviewboard-openlmi.rhcloud.com/r/420/diff/ Testing ------- Thanks, Radek Novacek

1 0

Re: Review Request 419: openlmi-networking [2/4] Implement some more properties of defined classes
by Stephen Gallagher 30 May '13

30 May '13

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/419/ ----------------------------------------------------------- (Updated May 30, 2013, 10:03 a.m.) Status ------ This change has been marked as submitted. Review request for OpenLMI Developers. Repository: openlmi-networking Description ------- Implement some more properties of defined classes Diffs ----- mof/LMI_Networking.mof d03d6e1c06c5fe2f17711816ab29c1cef4e91c88 src/LMI_EthernetPortProvider.c 78df2e0f10b478984a5d13dcd020377bd6283603 src/LMI_IPNetworkConnectionCapabilitiesProvider.c cd5fac1701378399b5a06634ab46aad1a1b91153 src/LMI_IPNetworkConnectionProvider.c a312e5571db0d7e8867f768b81365708b53d6657 src/LMI_IPVersionSettingDataProvider.c 79ab767531e768b767c5316b91542d270d9b1918 Diff: http://reviewboard-openlmi.rhcloud.com/r/419/diff/ Testing ------- Thanks, Radek Novacek

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

openlmi-reviews May 2013