Review Request 1285: Define OpenLMI 1.0.0
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1285/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Define OpenLMI 1.0.0
Set strict version dependencies for the meta-package
Diffs
-----
openlmi-providers.spec aa2225fcac396ac49ffad95c99a9241e5825dda1
Diff: http://reviewboard-openlmi.rhcloud.com/r/1285/diff/
Testing
-------
Built the package, verified that the resulting openlmi meta-package has:
openlmi-account = 0.4.1-3.fc21
openlmi-hardware = 0.4.1-3.fc21
openlmi-networking = 0.2.1
openlmi-powermanagement = 0.4.1-3.fc21
openlmi-providers = 1.0.0-3.fc21
openlmi-service = 0.4.1-3.fc21
openlmi-software = 0.4.1-3.fc21
openlmi-storage = 0.7.0
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
tog-pegasus
rpmlib(PayloadIsXz) <= 5.2-1
Thanks,
Stephen Gallagher
10 years, 5 months
Review Request 1322: [2/3] Fix typos in docstrings.
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1322/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
-------
Fix typos in docstrings.
Diffs
-----
mof/LMI_Storage-Base.mof 2e7198a78982fe192992a59ee2757464199720a4
mof/LMI_Storage-BlockStorage.mof 060650a353706d0e049207e253cdcddf6e3b5ee1
src/lmi/storage/LMI_LocalFileSystem.py 63bfb52a81a61e1ff6c7faa7d559c69dae3d3836
src/lmi/storage/LMI_TransientFileSystem.py e080869574975846feffba20ee8f215ed2329590
Diff: http://reviewboard-openlmi.rhcloud.com/r/1322/diff/
Testing
-------
Thanks,
Jan Synacek
10 years, 5 months
Review Request 1321: [1/3] Fix superfluous whitespaces in docstrings.
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1321/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
-------
Fix superfluous whitespaces in docstrings.
Diffs
-----
mof/LMI_Storage-Base.mof 1f901442d9b3468f9a07b7973f73dc0c2e09b434
mof/LMI_Storage-BlockStorage.mof bf82c2bce83f65e1ab170c40866a23206d55db65
mof/LMI_Storage-Filesystem.mof 04908fdd8c89d955f36bbe8169ee7e13e1f62cf3
mof/LMI_Storage-Partitions.mof 509b86f4864105cb194b713f8b0e528439458d70
src/lmi/storage/LMI_DiskPartitioningConfigurationService.py 9739d3e5b0911fc5f061c1d681ee58397cd9ab95
src/lmi/storage/LMI_FileSystemConfigurationService.py bb6f3eb846483e31e9e88860762022464de7987a
src/lmi/storage/LMI_StorageConfigurationService.py 231880f9b9c88d508f0c48247558230648e14c0b
Diff: http://reviewboard-openlmi.rhcloud.com/r/1321/diff/
Testing
-------
Thanks,
Jan Synacek
10 years, 5 months
Review Request 1324: account: Initialize NULL the group array to prevent bad memory access
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1324/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
account: Initialize NULL the group array to prevent bad memory access
Found by clang analysis:
Error: PW.BRANCH_PAST_INITIALIZATION:
openlmi-providers-0.4.1_75_gf47c906/src/account/LMI_AccountProvider.c:324: branch_past_initialization: transfer of control bypasses initialization of:
openlmi-providers-0.4.1_75_gf47c906/src/account/LMI_AccountProvider.c:324: caretline: ^
openlmi-providers-0.4.1_75_gf47c906/src/account/LMI_AccountProvider.c:324: name_at_decl_position: variable "groups" (declared at line 328)
Diffs
-----
src/account/LMI_AccountProvider.c 35c870f6a5325c59999539e34e560ba625c6cbca
Diff: http://reviewboard-openlmi.rhcloud.com/r/1324/diff/
Testing
-------
Thanks,
Tomáš Bžatek
10 years, 5 months