On Dec. 2, 2013, 2:20 p.m., scanbot wrote:
> Autoscan finished with errors:
> Error: PW.BRANCH_PAST_INITIALIZATION:
> openlmi-providers-0.4.1_75_gf47c906/src/account/LMI_AccountProvider.c:324:
branch_past_initialization: transfer of control bypasses initialization of:
> openlmi-providers-0.4.1_75_gf47c906/src/account/LMI_AccountProvider.c:324:
caretline: ^
> openlmi-providers-0.4.1_75_gf47c906/src/account/LMI_AccountProvider.c:324:
name_at_decl_position: variable "groups" (declared at line 328)
>
> Scanned reviews: 1318
Not related, submitted as review 1324.
- Tomáš
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1318/#review1873
-----------------------------------------------------------
On Dec. 2, 2013, 12:41 p.m., Tomáš Bžatek wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1318/
-----------------------------------------------------------
(Updated Dec. 2, 2013, 12:41 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
account: Fall back to /etc/passwd if /etc/shadow returns NULL password
In certain cases password may be stored in /etc/passwd directly and we
need to tell libuser where to pull the password from. This patch
automatically falls back to /etc/passwd if there's no password found
in /etc/shadow. In case password retrieval fails in both cases, the
UserPassword and UserPasswordEncoding LMI_Account properties are left
unset.
Based on a patch by Klaus Kämpf <kkaempf(a)suse.de>
https://bugzilla.redhat.com/show_bug.cgi?id=1031334
Diffs
-----
src/account/LMI_AccountProvider.c 35c870f6a5325c59999539e34e560ba625c6cbca
Diff:
http://reviewboard-openlmi.rhcloud.com/r/1318/diff/
Testing
-------
Thanks,
Tomáš Bžatek