-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1324/#review1880
-----------------------------------------------------------
Autoscan finished OK
Scanned reviews: 1324
- scanbot
On Dec. 2, 2013, 2:58 p.m., Tomáš Bžatek wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1324/
-----------------------------------------------------------
(Updated Dec. 2, 2013, 2:58 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
account: Initialize NULL the group array to prevent bad memory access
Found by clang analysis:
Error: PW.BRANCH_PAST_INITIALIZATION:
openlmi-providers-0.4.1_75_gf47c906/src/account/LMI_AccountProvider.c:324:
branch_past_initialization: transfer of control bypasses initialization of:
openlmi-providers-0.4.1_75_gf47c906/src/account/LMI_AccountProvider.c:324: caretline:
^
openlmi-providers-0.4.1_75_gf47c906/src/account/LMI_AccountProvider.c:324:
name_at_decl_position: variable "groups" (declared at line 328)
Diffs
-----
src/account/LMI_AccountProvider.c 35c870f6a5325c59999539e34e560ba625c6cbca
Diff:
http://reviewboard-openlmi.rhcloud.com/r/1324/diff/
Testing
-------
Thanks,
Tomáš Bžatek