Review Request 1315: lmishell, add missing log messages to connect()
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1315/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description
-------
The patch introduces some useful log messages in the connect() function. When connecting to CIMOM, 2 situations may occur:
1. user has provided valid username+password/certificate or is connected via Unix-socket:
- in that case, output INFO message with "Connected" string
- by default, lmishell outputs only ERROR messages, so no message will be print out
- to see the message of successful connection, run lmishell with "-v" or "-m" CLI option
2. user has provided invalid username+password/certificate:
- output ERROR message with "Not connected" string
- the log message can be suppressed by running lmishell with "-q" CLI option
Diffs
-----
cli/lmi/shell/LMIConnection.py 301fa520d8eacb39676af5e9ff479c3583df864e
cli/lmishell e493af571c72b9ffc22a500b6716d037faec88c3
Diff: http://reviewboard-openlmi.rhcloud.com/r/1315/diff/
Testing
-------
Thanks,
Peter Hatina
10 years, 5 months