On Aug. 20, 2013, 6:26 a.m., Radek Novacek wrote:
> src/journald/test/TestIndications.py, line 33
>
<
http://reviewboard-openlmi.rhcloud.com/r/731/diff/1/?file=4089#file4089li...
>
> It should be:
> "test_good_filter_%d" % (time.time() * 1000)
>
> Otherwise it will copy "test_good_filter_1231312" a thousand times
Yes it does that indeed, however that proved to be working :-)
This was a copy-paste code from account tests, same issue there. My long-term intention
was to make the code shared.
On Aug. 20, 2013, 6:26 a.m., Radek Novacek wrote:
> src/journald/instutil.c, line 128
>
<
http://reviewboard-openlmi.rhcloud.com/r/731/diff/1/?file=4088#file4088li...
>
> Logging should be done with error/warn/error so it goes via CMPI to CIMOM's
standard log.
This will come as a next patch.
- Tomáš
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/731/#review925
-----------------------------------------------------------
On Aug. 20, 2013, 3:20 p.m., Tomáš Bžatek wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/731/
-----------------------------------------------------------
(Updated Aug. 20, 2013, 3:20 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
journald: Add indications
Also contains simple test suite to test indications.
Still contains some TODOs as there's a copy-pasted code that could live in a shared
place.
Diffs
-----
mof/60_LMI_Journald.mof PRE-CREATION
src/journald/CMakeLists.txt PRE-CREATION
src/journald/LMI_JournalLogRecordInstanceCreationIndicationProvider.c PRE-CREATION
src/journald/instutil.h PRE-CREATION
src/journald/instutil.c PRE-CREATION
src/journald/test/TestIndications.py PRE-CREATION
src/journald/test/common.py PRE-CREATION
src/journald/test/localtest.sh PRE-CREATION
Diff:
http://reviewboard-openlmi.rhcloud.com/r/731/diff/
Testing
-------
Thanks,
Tomáš Bžatek