This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/731/

On August 23rd, 2013, 8:29 a.m. UTC, Jan Safranek wrote:

mof/60_LMI_Journald.mof (Diff revision 2)
66
[ Version("0.0.1"), Provider("cmpi:cmpiLMI_Journald"),
You should use global version, 0.2.0 in this case. All the classes and providers in openlmi-providers share the same version and if you add new class of features to existing class, you should bump it there (software provider has already bumped in in the spec and cmake for this release).
Changed to 0.2.0 for consistency with proposed change in software provider (review #742)

- Tomáš


On August 23rd, 2013, 12:56 p.m. UTC, Tomáš Bžatek wrote:

Review request for OpenLMI Developers.
By Tomáš Bžatek.

Updated Aug. 23, 2013, 12:56 p.m.

Repository: openlmi-providers

Description

journald: Add indications
    
Also contains simple test suite to test indications.


Still contains some TODOs as there's a copy-pasted code that could live in a shared place.

Diffs

  • mof/60_LMI_Journald.mof (85dad2b07af23ce67ad9f266c977bc340d46de34)
  • src/journald/CMakeLists.txt (7a4de06d7a028f965e07795c6b6dc94545d16839)
  • src/journald/LMI_JournalLogRecordInstanceCreationIndicationProvider.c (PRE-CREATION)
  • src/journald/instutil.h (ef02aa189ac2c399f66a5700959b96c52f79d033)
  • src/journald/instutil.c (2164aa9c6bd8f1194e7d69ea7ddcede444616c2e)
  • src/journald/test/TestIndications.py (PRE-CREATION)
  • src/journald/test/common.py (PRE-CREATION)
  • src/journald/test/localtest.sh (PRE-CREATION)

View Diff