This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/731/

src/journald/instutil.c (Diff revision 1)
128
            fprintf(stderr, "ind_init(): Error opening journal: %s\n", strerror(-r));
Logging should be done with error/warn/error so it goes via CMPI to CIMOM's standard log.

src/journald/test/TestIndications.py (Diff revision 1)
33
        filter_name = "test_good_filter_%d" % time.time() * 1000
It should be:
"test_good_filter_%d" % (time.time() * 1000)

Otherwise it will copy "test_good_filter_1231312" a thousand times

- Radek Novacek


On August 19th, 2013, 4:53 p.m. CEST, Tomáš Bžatek wrote:

Review request for OpenLMI Developers.
By Tomáš Bžatek.

Updated Aug. 19, 2013, 4:53 p.m.

Repository: openlmi-providers

Description

journald: Add indications
    
Also contains simple test suite to test indications.


Still contains some TODOs as there's a copy-pasted code that could live in a shared place.

Diffs

  • mof/60_LMI_Journald.mof (PRE-CREATION)
  • src/journald/CMakeLists.txt (PRE-CREATION)
  • src/journald/LMI_JournalLogRecordInstanceCreationIndicationProvider.c (PRE-CREATION)
  • src/journald/instutil.h (PRE-CREATION)
  • src/journald/instutil.c (PRE-CREATION)
  • src/journald/test/TestIndications.py (PRE-CREATION)
  • src/journald/test/common.py (PRE-CREATION)
  • src/journald/test/localtest.sh (PRE-CREATION)

View Diff