This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/731/ |
src/journald/instutil.c (Diff revision 1) | |||
---|---|---|---|
128 | fprintf(stderr, "ind_init(): Error opening journal: %s\n", strerror(-r)); |
Logging should be done with error/warn/error so it goes via CMPI to CIMOM's standard log.
src/journald/test/TestIndications.py (Diff revision 1) | |||
---|---|---|---|
33 | filter_name = "test_good_filter_%d" % time.time() * 1000 |
It should be: "test_good_filter_%d" % (time.time() * 1000) Otherwise it will copy "test_good_filter_1231312" a thousand times
- Radek Novacek
On August 19th, 2013, 4:53 p.m. CEST, Tomáš Bžatek wrote:
Review request for OpenLMI Developers.
By Tomáš Bžatek.
Updated Aug. 19, 2013, 4:53 p.m.
Repository:
openlmi-providers
Description
Diffs
|