On March 28, 2014, 9:44 a.m., Michal Minar wrote:
> src/software-dbus/LMI_SoftwareIdentityResourceProvider.c, line 70
>
<
http://reviewboard-openlmi.rhcloud.com/r/1566/diff/1/?file=8662#file8662l...
>
> I'm concerned about error message reporting. PackageKit may offer detailed
description why some task failed. This is one of the major issues of python software
provider - it does not provide any information in error cases. Please do not avoid using
last *error* argument.
check_and_create_error_msg() function should check for any error messages from PackageKit,
but I found out, that it doesn't work exactly as expected - I need to update this
error reporting also in SoftwareIdentity provider. If this is your only comment, I would
push this patch to the git as it is, and then fix the error reporting in next patch, if
you agree.
- Peter
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1566/#review2386
-----------------------------------------------------------
On March 27, 2014, 5:30 p.m., Peter Schiffer wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1566/
-----------------------------------------------------------
(Updated March 27, 2014, 5:30 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Software-dbus: Implemented SoftwareIdentityResourceProvider
Diffs
-----
src/software-dbus/LMI_Software.h 916ca5f1c95646bf7969ef74b8aff42ecee281b2
src/software-dbus/LMI_SoftwareIdentityResourceProvider.c
d173b484d3745455d507d1557a17f3191635d03c
Diff:
http://reviewboard-openlmi.rhcloud.com/r/1566/diff/
Testing
-------
Thanks,
Peter Schiffer