This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1566/ |
src/software-dbus/LMI_SoftwareIdentityResourceProvider.c (Diff revision 1) | |||
---|---|---|---|
static CMPIStatus LMI_SoftwareIdentityResourceEnumInstances( |
|||
70 | results = pk_task_get_repo_list_sync(task, 0, NULL, NULL, NULL, NULL); |
I'm concerned about error message reporting. PackageKit may offer detailed description why some task failed. This is one of the major issues of python software provider - it does not provide any information in error cases. Please do not avoid using last *error* argument.
src/software-dbus/LMI_SoftwareIdentityResourceProvider.c (Diff revision 1) | |||
---|---|---|---|
static CMPIStatus LMI_SoftwareIdentityResourceInvokeMethod( |
|||
287 | results = pk_task_repo_enable_sync(task, self->Name.chars, enable, NULL, |
Let's check for errors (last argument).
- Michal Minar
On March 27th, 2014, 4:30 p.m. UTC, Peter Schiffer wrote:
Review request for OpenLMI Developers.
By Peter Schiffer.
Updated March 27, 2014, 4:30 p.m.
Repository:
openlmi-providers
Description
Diffs
|