This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1566/

On March 28th, 2014, 8:44 a.m. UTC, Michal Minar wrote:

src/software-dbus/LMI_SoftwareIdentityResourceProvider.c (Diff revision 1)
static CMPIStatus LMI_SoftwareIdentityResourceEnumInstances(
70
    results = pk_task_get_repo_list_sync(task, 0, NULL, NULL, NULL, NULL);
I'm concerned about error message reporting. PackageKit may offer detailed description why some task failed. This is one of the major issues of python software provider - it does not provide any information in error cases. Please do not avoid using last *error* argument.

On March 28th, 2014, 9:11 a.m. UTC, Peter Schiffer wrote:

check_and_create_error_msg() function should check for any error messages from PackageKit, but I found out, that it doesn't work exactly as expected - I need to update this error reporting also in SoftwareIdentity provider. If this is your only comment, I would push this patch to the git as it is, and then fix the error reporting in next patch, if you agree.
Thanks for deeper breakdown, ship it!

- Michal


On March 27th, 2014, 4:30 p.m. UTC, Peter Schiffer wrote:

Review request for OpenLMI Developers.
By Peter Schiffer.

Updated March 27, 2014, 4:30 p.m.

Repository: openlmi-providers

Description

Software-dbus: Implemented SoftwareIdentityResourceProvider

Diffs

  • src/software-dbus/LMI_Software.h (916ca5f1c95646bf7969ef74b8aff42ecee281b2)
  • src/software-dbus/LMI_SoftwareIdentityResourceProvider.c (d173b484d3745455d507d1557a17f3191635d03c)

View Diff