-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1147/#review1567
-----------------------------------------------------------
Besides the issues found by Radek and smaller typos, I like it.
src/software/test/testSoftware.py
<
http://reviewboard-openlmi.rhcloud.com/r/1147/#comment969>
mask -> mark
src/software/test/testSoftware.py
<
http://reviewboard-openlmi.rhcloud.com/r/1147/#comment970>
missing closing '}'
src/software/test/testSoftware.py
<
http://reviewboard-openlmi.rhcloud.com/r/1147/#comment971>
I like this. Nice and simple.
src/software/test/testSoftware.py
<
http://reviewboard-openlmi.rhcloud.com/r/1147/#comment973>
packags -> packages
src/software/test/testSoftware.py
<
http://reviewboard-openlmi.rhcloud.com/r/1147/#comment978>
*inst* is a little bit misleading. I would add an 's' to it:
insts = ...
- Michal Minar
On Oct. 30, 2013, 2:03 p.m., Jan Grec wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1147/
-----------------------------------------------------------
(Updated Oct. 30, 2013, 2:03 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
software - tests: software test suite with basic tests
This is only a "current-status" review. I'll be very thankful for any
comments on what's wrong, how the structure should look like, etc.
My TODO is to
* repair all broken tests
* add all tests mentioned
* bind test suite with new LmiTestCase class
I apologize for inconvenience, but I wasn't able to save previous review notes.
Diffs
-----
src/software/test/lmi-test.repo PRE-CREATION
src/software/test/testSoftware.py PRE-CREATION
Diff:
http://reviewboard-openlmi.rhcloud.com/r/1147/diff/
Testing
-------
Thanks,
Jan Grec