This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1147/

Besides the issues found by Radek and smaller typos, I like it.

src/software/test/testSoftware.py (Diff revision 1)
85
    If string contains asterisk or exclamation mask as a first character,
mask -> mark

src/software/test/testSoftware.py (Diff revision 1)
113
        dic{"all": [REPOS], "enabled": [REPOS], "disabled": [REPOS]
missing closing '}'

src/software/test/testSoftware.py (Diff revision 1)
126
        # If line doesn't contain enabled/disabled, it's simply not a repo
I like this. Nice and simple.

src/software/test/testSoftware.py (Diff revision 1)
252
                            "OpenLMI returned empty list of installed packags")
packags -> packages

src/software/test/testSoftware.py (Diff revision 1)
272
            inst = rep.associator_names(Role="AvailableSAP",
*inst* is a little bit misleading. I would add an 's' to it:
  insts = ...

- Michal Minar


On October 30th, 2013, 2:03 p.m. UTC, Jan Grec wrote:

Review request for OpenLMI Developers.
By Jan Grec.

Updated Oct. 30, 2013, 2:03 p.m.

Repository: openlmi-providers

Description

software - tests: software test suite with basic tests

This is only a "current-status" review. I'll be very thankful for any comments on what's wrong, how the structure should look like, etc.

My TODO is to
  * repair all broken tests
  * add all tests mentioned
  * bind test suite with new LmiTestCase class

I apologize for inconvenience, but I wasn't able to save previous review notes.

Diffs

  • src/software/test/lmi-test.repo (PRE-CREATION)
  • src/software/test/testSoftware.py (PRE-CREATION)

View Diff