-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1760/#review2670
-----------------------------------------------------------
Ship it!
I don't have a strong opinion about remarks below. Otherwise it looks good to me. Feel
free to ship it.
mof/60_LMI_Journald.mof
<
http://reviewboard-openlmi.rhcloud.com/r/1760/#comment1484>
Having 2 IDs signed and one unsigned looks weird. If I take a look at CIM schema,
UserID and GroupID properties are strings but there's also CIM_UnixProcess with
RealUserID and RealGroupID. They are uint64 properties.
IMHO in this case there's no harm in sticking to CIM convention.
mof/60_LMI_Journald.mof
<
http://reviewboard-openlmi.rhcloud.com/r/1760/#comment1483>
I don't know much about logging facilities, but is this information always known?
I'm missing something like "unknown" in possible values.
- Michal Minar
On Kvě. 22, 2014, 3:36 odp., Tomáš Bžatek wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1760/
-----------------------------------------------------------
(Updated Kvě. 22, 2014, 3:36 odp.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
This is useful e.g. for indication filtering.
Diffs
-----
mof/60_LMI_Journald.mof 938b3d282029d7b8c91d6ccc03efab150a79c22d
src/journald/instutil.c b3987bccf2b4a641e384ef96f3de260c58a5ac44
Diff:
http://reviewboard-openlmi.rhcloud.com/r/1760/diff/
Testing
-------
Thanks,
Tomáš Bžatek