On May 23, 2014, 7:18 a.m., Michal Minar wrote:
> mof/60_LMI_Journald.mof, lines 228-242
>
<
http://reviewboard-openlmi.rhcloud.com/r/1760/diff/1/?file=9986#file9986l...
>
> Having 2 IDs signed and one unsigned looks weird. If I take a look at CIM
schema, UserID and GroupID properties are strings but there's also CIM_UnixProcess
with RealUserID and RealGroupID. They are uint64 properties.
>
> IMHO in this case there's no harm in sticking to CIM convention.
Hmm, right, good idea. I'm tempted to use String to stay consistent but it's
really odd. Besides, numbers allow easier range filtering in WQL/CQL and type conversion
is easy in Python/lmishell. Anyway, changed to uint64.
On May 23, 2014, 7:18 a.m., Michal Minar wrote:
> mof/60_LMI_Journald.mof, lines 250-253
>
<
http://reviewboard-openlmi.rhcloud.com/r/1760/diff/1/?file=9986#file9986l...
>
> I don't know much about logging facilities, but is this information always
known? I'm missing something like "unknown" in possible values.
If the journal item field is unknown or missing, the property is simply not set. I've
added more conditions to ensure values are in the range.
- Tomáš
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1760/#review2670
-----------------------------------------------------------
On May 23, 2014, 2:47 p.m., Tomáš Bžatek wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1760/
-----------------------------------------------------------
(Updated May 23, 2014, 2:47 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
This is useful e.g. for indication filtering.
Diffs
-----
mof/60_LMI_Journald.mof 938b3d282029d7b8c91d6ccc03efab150a79c22d
src/journald/instutil.c b3987bccf2b4a641e384ef96f3de260c58a5ac44
Diff:
http://reviewboard-openlmi.rhcloud.com/r/1760/diff/
Testing
-------
Thanks,
Tomáš Bžatek