+++ Michael DeHaan [13/08/08 15:31 -0400]:
You may want to add calling to check_token() (or is it
"token_check"?)
prior to token usage, or at least test what happens when the token
expires. I'm not sure if the code is doing that or not, but I thought
I would point it out.
Not logging in repeatedly would be a good thing -- it produces extra log
entries and depending on what you are authing against, may incur some lag.
I was thinking about how to handle checks for that but wasn't sure of a good
path. One way would be to, on a writable call, retry a failed call once by
assuming the auth_token had expired.
It all depends on how seamless the need for a log should be. If the framework
doesn't bother trying to hide it, then an expired auth_token will just result
in a failed attempt to update the Cobbler server. But, if we try to handle it
then we take on a heck of a task.
Ideas?
--
Darryl L. Pierce, Sr. Software Engineer
Red Hat, Inc. -
http://www.redhat.com/
oVirt - Virtual Machine Management -
http://www.ovirt.org/
"What do you care what other people think, Mr. Feynman?"