Won't that break older Centos/RHEL/Fedora where, like RHEL 5, where
tftpd.what returns "in_tftpd"? Or are they no longer supported?
I was hoping to make this my first pull request for this project! Oh well,
next time maybe. Thanks for helping, Jörgen.
--Greg
On Sun, Sep 14, 2014 at 3:28 AM, Jörgen Maas <jorgen.maas(a)gmail.com> wrote:
Hi,
Thanks for reporting this issue.
I've got the following fix into master and release26
diff --git a/cobbler/modules/manage_in_tftpd.py
b/cobbler/modules/manage_in_tftpd.py
index b53672c..578fd3f 100644
--- a/cobbler/modules/manage_in_tftpd.py
+++ b/cobbler/modules/manage_in_tftpd.py
@@ -40,7 +40,7 @@ def register():
class InTftpdManager:
def what(self):
- return "tftpd"
+ return "in_tftpd"
def __init__(self, config, logger):
"""
On Sat, Sep 13, 2014 at 8:14 PM, Greg Chavez <greg.chavez(a)gmail.com>
wrote:
>
> Cloned Cobbler 2.6.5 onto CentOS 6.5, installed as an rpm.
>
> Among the usual cobbler check warnings from a new install, I was getting
> this:
>
> 1 : Unmanaged tftpd server 'tftpd'
>
> And this was despite having the system tftp-server package installed and
> enabled in xinetd. I poked around and found these lines in
> python2.6/site-packages/cobbler/action_check.py (72-83):
>
> mode = self.config.api.get_sync().tftpd.what()
> self.check_tftpd_dir(status)
> if mode == "in_tftpd":
> self.check_tftpd_bin(status)
> self.check_tftpd_conf(status)
> elif mode == "tftpd_py":
> self.check_ctftpd_bin(status)
> self.check_ctftpd_conf(status)
> else :
> status.append("Unmanaged tftpd server '%s'" % mode)
>
> Simply changing in_tftpd to tftpd, cleared the check warning. But before
> I make a pull request, I wanted to ask if perhaps the issue is not this
> code but tftpd.what. I am not a python programmer, so of I can't
> find/xargs/grep it out, I likely can't figure out what's going on.
>
> What's the right way to fix this?
>
> Thanks.
>
> --
> \*..+.-
> --Greg Chavez
> +//..;};
>
> _______________________________________________
>
>