Charles Duffy wrote:
> Running with a modern pykickstart (as opposed to the one included in
> RHEL5) does much better; however, errors still don't appear to be
> passed out to the shell:
>
> ----------------------------
> checking url:
http://169.254.0.1/cblr/svc/op/ks/system/00:16:3e:67:2b:43
> General error in input file: 'str' object has no attribute
'partition'
> ----------------------------
> checking url:
http://169.254.0.1/cblr/svc/op/ks/system/00:16:3e:c9:95:47
> General error in input file: 'str' object has no attribute
'partition'
> *** potential errors detected in kickstarts ***
> [root@cobbler ~]# echo $?
> 0
>
>
> By contrast, this version of pykickstart *does* correctly reflect
> errors in its exit status:
>
>
> [root@cobbler ~]# ksvalidator
>
http://169.254.0.1/cblr/svc/op/ks/system/00:16:3e:c9:95:47; echo $?
> General error in input file: 'str' object has no attribute
'partition'
> 1
>
>
> See attached patch.
> ------------------------------------------------------------------------
>
> _______________________________________________
> cobbler mailing list
> cobbler(a)lists.fedorahosted.org
>
https://fedorahosted.org/mailman/listinfo/cobbler
>
Applied to devel branch, thanks!
--Michael
_______________________________________________
cobbler mailing list
cobbler(a)lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/cobbler
I modified this slightly...
rc = BootCLI().run(sys.argv)
if rc == True:
return 0
elif rc == False:
return 1
return rc
This makes things now return 0/1 as appropriate.