On Dec. 17, 2013, 1:44 p.m., Michal Minar wrote:
> src/journald/test/TestIterators.py, line 74
>
<
http://reviewboard-openlmi.rhcloud.com/r/1378/diff/1/?file=7058#file7058l...
>
> These loooong lines make my web browser cry :(.
Wrapped.
On Dec. 17, 2013, 1:44 p.m., Michal Minar wrote:
> src/journald/test/TestIterators.py, lines 47-48
>
<
http://reviewboard-openlmi.rhcloud.com/r/1378/diff/1/?file=7058#file7058l...
>
> I prefer not to use the dict:
> inst.GetRecord(PositionToNext=False,
IterationIdentifier=rfirst['IterationIdentifier'])
> This is a matter of taste. I'm only pointing it out in case you didn't
know.
I have no strict reason for that, still learning Python habits. Perhaps I used to have a
reason before, can't remember now.
- Tomáš
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1378/#review1993
-----------------------------------------------------------
On Jan. 2, 2014, 5:34 p.m., Tomáš Bžatek wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1378/
-----------------------------------------------------------
(Updated Jan. 2, 2014, 5:34 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
journald: Port tests to lmishell base
Diffs
-----
src/journald/test/TestIndications.py f25c97956a815193cff21ec876cc3502d4ee2a6c
src/journald/test/TestIterators.py fd90a1229cccd7999e00d040ac804e5d7f7ffd20
src/journald/test/TestWriting.py 39891a5f3180cce973cf3d3bfa004443c6125ccd
src/journald/test/journald_common.py beec26744f16adda0130b5e0299d203b9f618d74
Diff:
http://reviewboard-openlmi.rhcloud.com/r/1378/diff/
Testing
-------
Thanks,
Tomáš Bžatek