This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1378/ |
On December 17th, 2013, 1:44 p.m. UTC, Michal Minar wrote:
src/journald/test/TestIterators.py (Diff revision 1) 47 (retval, rget, errorstr) = inst.GetRecord({'PositionToNext': False,48 'IterationIdentifier': rfirst['IterationIdentifier']})I prefer not to use the dict: inst.GetRecord(PositionToNext=False, IterationIdentifier=rfirst['IterationIdentifier']) This is a matter of taste. I'm only pointing it out in case you didn't know.
I have no strict reason for that, still learning Python habits. Perhaps I used to have a reason before, can't remember now.
On December 17th, 2013, 1:44 p.m. UTC, Michal Minar wrote:
src/journald/test/TestIterators.py (Diff revision 1) 67 iter_id = "LMI_JournalMessageLog_CMPI_Iter_9878972#0x7f8504021380#s=a13c10bf472048e69dceeee118cd7f84;i=3;b=5b96431d996a416ebf11dbb6543a5084;m=221f7b;t=4dcc1b6e70a7a;x=b1b572ade816b92e"72 iter_id = "LMI_JournalMessageLog_CMPI_Iter_9878972#0x7f8504021380#s=a13c10bf472048e69dceeee118cd7f84;i=3;b=5b96431d996a416ebf11dbb6543a5084;m=221f7b;t=4dcc1b6e70a7a;x=b1b572ade816b92e"These loooong lines make my web browser cry :(.
Wrapped.
- Tomáš
On January 2nd, 2014, 5:34 p.m. UTC, Tomáš Bžatek wrote:
Review request for OpenLMI Developers.
By Tomáš Bžatek.
Updated Jan. 2, 2014, 5:34 p.m.
Repository:
openlmi-providers
Description
Diffs
|