On Čer. 10, 2014, 1:02 odp., Peter Schiffer wrote:
> src/software-dbus/sw-utils.c, line 588
>
<
http://reviewboard-openlmi.rhcloud.com/r/1775/diff/1/?file=10096#file1009...
>
> nitpick: in situations like this I would prefer to set pkg_id to NULL after
free, as later you are passing it again to the g_object_get() fn; but it should be
harmless as it is now
You're right, it's safer this way.
- Michal
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1775/#review2712
-----------------------------------------------------------
On Čer. 10, 2014, 1:10 odp., Michal Minar wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1775/
-----------------------------------------------------------
(Updated Čer. 10, 2014, 1:10 odp.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
support older versions of PackageKit api
Functions like:
pk_details_get_package_id
pk_details_get_description
are available since version 0.8.12. In RHEL7 we have 0.8.9. Let's avoid
using them.
Diffs
-----
src/software-dbus/sw-utils.c 6b1424d66e8a83f74db83157771b6f30d651e184
Diff:
http://reviewboard-openlmi.rhcloud.com/r/1775/diff/
Testing
-------
Thanks,
Michal Minar