This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1775/ |
On červen 10th, 2014, 1:02 odp. UTC, Peter Schiffer wrote:
src/software-dbus/sw-utils.c (Diff revision 1) void enum_sw_identity_instances(PkBitfield filters, const CMPIBroker *cb,588 g_free(pkg_id);nitpick: in situations like this I would prefer to set pkg_id to NULL after free, as later you are passing it again to the g_object_get() fn; but it should be harmless as it is now
You're right, it's safer this way.
- Michal
On červen 10th, 2014, 1:10 odp. UTC, Michal Minar wrote:
Review request for OpenLMI Developers.
By Michal Minar.
Updated Čer. 10, 2014, 1:10 odp.
Repository:
openlmi-providers
Description
Diffs
|