----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1874/ -----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
Add lmi_polkit_init/shutdown function.
New library libopenlmipolkitagent is created, so libopenlmicommon and providers do not require polkit unless the providers actually use it.
Diffs -----
CMakeLists.txt f2900abec0ba4b54fed481b7d1390eaed2ba1593 src/CMakeLists.txt 0b8a8ff29c7a0c6af4ee2ba0025578c0659f3aa3 src/libs/polkitagent/CMakeLists.txt PRE-CREATION src/libs/polkitagent/openlmipolkitagent.pc.in PRE-CREATION src/libs/polkitagent/polkit_agent.h PRE-CREATION src/libs/polkitagent/polkit_agent.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1874/diff/
Testing -------
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1874/#review2982 -----------------------------------------------------------
Autoscan started for review(s) 1872[1], 1873[1], 1874[1], 1875[1], 1876[1], 1877[1], 1878[1], 1879[1]
- scanbot
On July 9, 2014, 11:39 a.m., Jan Safranek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1874/
(Updated July 9, 2014, 11:39 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Add lmi_polkit_init/shutdown function.
New library libopenlmipolkitagent is created, so libopenlmicommon and providers do not require polkit unless the providers actually use it.
Diffs
CMakeLists.txt f2900abec0ba4b54fed481b7d1390eaed2ba1593 src/CMakeLists.txt 0b8a8ff29c7a0c6af4ee2ba0025578c0659f3aa3 src/libs/polkitagent/CMakeLists.txt PRE-CREATION src/libs/polkitagent/openlmipolkitagent.pc.in PRE-CREATION src/libs/polkitagent/polkit_agent.h PRE-CREATION src/libs/polkitagent/polkit_agent.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1874/diff/
Testing
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1874/#review2992 -----------------------------------------------------------
Autoscan failed: FAILED This can indicate any failure like broken buildroot to patch failed to apply. Manual investigation of scan log is needed. Scanned reviews: 1872,1873,1874,1875,1876,1877,1878,1879
- scanbot
On July 9, 2014, 11:39 a.m., Jan Safranek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1874/
(Updated July 9, 2014, 11:39 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Add lmi_polkit_init/shutdown function.
New library libopenlmipolkitagent is created, so libopenlmicommon and providers do not require polkit unless the providers actually use it.
Diffs
CMakeLists.txt f2900abec0ba4b54fed481b7d1390eaed2ba1593 src/CMakeLists.txt 0b8a8ff29c7a0c6af4ee2ba0025578c0659f3aa3 src/libs/polkitagent/CMakeLists.txt PRE-CREATION src/libs/polkitagent/openlmipolkitagent.pc.in PRE-CREATION src/libs/polkitagent/polkit_agent.h PRE-CREATION src/libs/polkitagent/polkit_agent.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1874/diff/
Testing
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1874/#review3001 -----------------------------------------------------------
Looks good to me (but I have no exp. with polkit).
src/libs/polkitagent/polkit_agent.h http://reviewboard-openlmi.rhcloud.com/r/1874/#comment1676
s/cann/call/
src/libs/polkitagent/polkit_agent.c http://reviewboard-openlmi.rhcloud.com/r/1874/#comment1677
unreleased error (see g_clear_error())
src/libs/polkitagent/polkit_agent.c http://reviewboard-openlmi.rhcloud.com/r/1874/#comment1678
`g_clear_object(identity);` does the same in one go.
src/libs/polkitagent/polkit_agent.c http://reviewboard-openlmi.rhcloud.com/r/1874/#comment1680
Forgotten debug statements?
src/libs/polkitagent/polkit_agent.c http://reviewboard-openlmi.rhcloud.com/r/1874/#comment1681
`g_clear_object()` allows to get rid of guards
- Michal Minar
On Čec. 9, 2014, 11:39 dop., Jan Safranek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1874/
(Updated Čec. 9, 2014, 11:39 dop.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Add lmi_polkit_init/shutdown function.
New library libopenlmipolkitagent is created, so libopenlmicommon and providers do not require polkit unless the providers actually use it.
Diffs
CMakeLists.txt f2900abec0ba4b54fed481b7d1390eaed2ba1593 src/CMakeLists.txt 0b8a8ff29c7a0c6af4ee2ba0025578c0659f3aa3 src/libs/polkitagent/CMakeLists.txt PRE-CREATION src/libs/polkitagent/openlmipolkitagent.pc.in PRE-CREATION src/libs/polkitagent/polkit_agent.h PRE-CREATION src/libs/polkitagent/polkit_agent.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1874/diff/
Testing
Thanks,
Jan Safranek
On Čec. 9, 2014, 3 odp., Michal Minar wrote:
src/libs/polkitagent/polkit_agent.c, lines 159-167 http://reviewboard-openlmi.rhcloud.com/r/1874/diff/1/?file=10943#file10943line159
Forgotten debug statements?
These log messages are quite valuable when debugging... I'll rephrase them to something more readable.
On Čec. 9, 2014, 3 odp., Michal Minar wrote:
src/libs/polkitagent/polkit_agent.c, lines 152-153 http://reviewboard-openlmi.rhcloud.com/r/1874/diff/1/?file=10943#file10943line152
`g_clear_object(identity);` does the same in one go.
Thanks, updated.
On Čec. 9, 2014, 3 odp., Michal Minar wrote:
src/libs/polkitagent/polkit_agent.c, lines 225-230 http://reviewboard-openlmi.rhcloud.com/r/1874/diff/1/?file=10943#file10943line225
`g_clear_object()` allows to get rid of guards
Done
- Jan
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1874/#review3001 -----------------------------------------------------------
On Čec. 9, 2014, 1:39 odp., Jan Safranek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1874/
(Updated Čec. 9, 2014, 1:39 odp.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Add lmi_polkit_init/shutdown function.
New library libopenlmipolkitagent is created, so libopenlmicommon and providers do not require polkit unless the providers actually use it.
Diffs
CMakeLists.txt f2900abec0ba4b54fed481b7d1390eaed2ba1593 src/CMakeLists.txt 0b8a8ff29c7a0c6af4ee2ba0025578c0659f3aa3 src/libs/polkitagent/CMakeLists.txt PRE-CREATION src/libs/polkitagent/openlmipolkitagent.pc.in PRE-CREATION src/libs/polkitagent/polkit_agent.h PRE-CREATION src/libs/polkitagent/polkit_agent.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1874/diff/
Testing
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1874/ -----------------------------------------------------------
(Updated Čec. 10, 2014, 10:47 dop.)
Review request for OpenLMI Developers.
Summary (updated) -----------------
openlmi-providers: polkit [3/8/8] Add lmi_polkit_init/shutdown function.
Repository: openlmi-providers
Description (updated) -------
Add lmi_polkit_init/shutdown function.
New library libopenlmipolkitagent is created, so libopenlmicommon and providers do not require polkit unless the providers actually use it.
Diffs (updated) -----
CMakeLists.txt f2900abec0ba4b54fed481b7d1390eaed2ba1593 src/CMakeLists.txt 0b8a8ff29c7a0c6af4ee2ba0025578c0659f3aa3 src/libs/polkitagent/CMakeLists.txt PRE-CREATION src/libs/polkitagent/openlmipolkitagent.pc.in PRE-CREATION src/libs/polkitagent/polkit_agent.h PRE-CREATION src/libs/polkitagent/polkit_agent.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1874/diff/
Testing -------
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1874/#review3014 -----------------------------------------------------------
Ship it!
Ship It!
- Michal Minar
On Čec. 10, 2014, 8:47 dop., Jan Safranek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1874/
(Updated Čec. 10, 2014, 8:47 dop.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Add lmi_polkit_init/shutdown function.
New library libopenlmipolkitagent is created, so libopenlmicommon and providers do not require polkit unless the providers actually use it.
Diffs
CMakeLists.txt f2900abec0ba4b54fed481b7d1390eaed2ba1593 src/CMakeLists.txt 0b8a8ff29c7a0c6af4ee2ba0025578c0659f3aa3 src/libs/polkitagent/CMakeLists.txt PRE-CREATION src/libs/polkitagent/openlmipolkitagent.pc.in PRE-CREATION src/libs/polkitagent/polkit_agent.h PRE-CREATION src/libs/polkitagent/polkit_agent.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1874/diff/
Testing
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1874/#review3019 -----------------------------------------------------------
I decided to rework the whole architecture based on Steff's comments. The polkit agent can be part of lmipolkitmarker.
- Jan Safranek
On Čec. 10, 2014, 10:47 dop., Jan Safranek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1874/
(Updated Čec. 10, 2014, 10:47 dop.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Add lmi_polkit_init/shutdown function.
New library libopenlmipolkitagent is created, so libopenlmicommon and providers do not require polkit unless the providers actually use it.
Diffs
CMakeLists.txt f2900abec0ba4b54fed481b7d1390eaed2ba1593 src/CMakeLists.txt 0b8a8ff29c7a0c6af4ee2ba0025578c0659f3aa3 src/libs/polkitagent/CMakeLists.txt PRE-CREATION src/libs/polkitagent/openlmipolkitagent.pc.in PRE-CREATION src/libs/polkitagent/polkit_agent.h PRE-CREATION src/libs/polkitagent/polkit_agent.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1874/diff/
Testing
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1874/ -----------------------------------------------------------
(Updated Čec. 10, 2014, 5:44 odp.)
Status ------
This change has been discarded.
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
Add lmi_polkit_init/shutdown function.
New library libopenlmipolkitagent is created, so libopenlmicommon and providers do not require polkit unless the providers actually use it.
Diffs -----
CMakeLists.txt f2900abec0ba4b54fed481b7d1390eaed2ba1593 src/CMakeLists.txt 0b8a8ff29c7a0c6af4ee2ba0025578c0659f3aa3 src/libs/polkitagent/CMakeLists.txt PRE-CREATION src/libs/polkitagent/openlmipolkitagent.pc.in PRE-CREATION src/libs/polkitagent/polkit_agent.h PRE-CREATION src/libs/polkitagent/polkit_agent.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1874/diff/
Testing -------
Thanks,
Jan Safranek
openlmi-reviews@lists.fedorahosted.org