This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1874/ |
On červenec 9th, 2014, 3 odp. CEST, Michal Minar wrote:
src/libs/polkitagent/polkit_agent.c (Diff revision 1) 152 if (identity)153 g_object_unref(identity);
g_clear_object(identity);
does the same in one go.
Thanks, updated.
On červenec 9th, 2014, 3 odp. CEST, Michal Minar wrote:
src/libs/polkitagent/polkit_agent.c (Diff revision 1) 159 lmi_debug("Callback here");160 g_warn_if_fail(g_simple_async_result_is_valid (res, G_OBJECT (listener), (gpointer) lmi_polkit_agent_initiate_authentication));161 162 if (g_simple_async_result_propagate_error(G_SIMPLE_ASYNC_RESULT(res), error)) {163 lmi_debug("Callback returns FALSE");164 return FALSE;165 }
166 167 lmi_debug("Callback returns TRUE");Forgotten debug statements?
These log messages are quite valuable when debugging... I'll rephrase them to something more readable.
On červenec 9th, 2014, 3 odp. CEST, Michal Minar wrote:
src/libs/polkitagent/polkit_agent.c (Diff revision 1) 225 if (subject)226 g_object_unref(subject);227 if (authority)228 g_object_unref(authority);229 if (listener)230 g_object_unref(listener);
g_clear_object()
allows to get rid of guards
Done
- Jan
On červenec 9th, 2014, 1:39 odp. CEST, Jan Safranek wrote:
Review request for OpenLMI Developers.
By Jan Safranek.
Updated Čec. 9, 2014, 1:39 odp.
Repository:
openlmi-providers
Description
Diffs
|