On Sept. 30, 2013, 6:18 a.m., Michal Minar wrote:
> cli/lmi/shell/LMIConnection.py, line 246
>
<
http://reviewboard-openlmi.rhcloud.com/r/894/diff/1/?file=4975#file4975li...
>
> IMHO this can not happen:
> bool(''.split('/')) is True
>
> I'd rather throw an exception for empty string (or maybe return self).
>
> In either case this should be mentioned in docstring.
I would rather drop the condition at line 246. In that case, the method will raise
LMINamespaceNotFound.
- Peter
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/894/#review1245
-----------------------------------------------------------
On Sept. 27, 2013, 12:07 p.m., Peter Hatina wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/894/
-----------------------------------------------------------
(Updated Sept. 27, 2013, 12:07 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description
-------
This patch introduces LMIConnection.get_namespace(); see
https://fedorahosted.org/openlmi/ticket/121
Example of usage:
cimv2 = conn.get_namespace("root/cimv2")
NOTE: Namespaces need to be separated by a slash sign, as seen in the example.
Diffs
-----
cli/lmi/shell/LMIConnection.py 3c00217b6b2cf00420ae69f46ebede9c6a0d1f5f
Diff:
http://reviewboard-openlmi.rhcloud.com/r/894/diff/
Testing
-------
Thanks,
Peter Hatina