This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/894/

On September 30th, 2013, 6:18 a.m. UTC, Michal Minar wrote:

cli/lmi/shell/LMIConnection.py (Diff revision 1)
246
        if not namespace_path:
IMHO this can not happen:
bool(''.split('/')) is True

I'd rather throw an exception for empty string (or maybe return self).

In either case this should be mentioned in docstring.
I would rather drop the condition at line 246. In that case, the method will raise LMINamespaceNotFound.

- Peter


On September 27th, 2013, 12:07 p.m. UTC, Peter Hatina wrote:

Review request for OpenLMI Developers.
By Peter Hatina.

Updated Sept. 27, 2013, 12:07 p.m.

Repository: openlmi-tools

Description

This patch introduces LMIConnection.get_namespace(); see https://fedorahosted.org/openlmi/ticket/121

Example of usage:

cimv2 = conn.get_namespace("root/cimv2")

NOTE: Namespaces need to be separated by a slash sign, as seen in the example.

Diffs

  • cli/lmi/shell/LMIConnection.py (3c00217b6b2cf00420ae69f46ebede9c6a0d1f5f)

View Diff