-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1667/#review2574
-----------------------------------------------------------
src/software-dbus/LMI_ResourceForSoftwareIdentityProvider.c
<
http://reviewboard-openlmi.rhcloud.com/r/1667/#comment1402>
It's usually better for readability to put these on separate lines.
src/software-dbus/LMI_ResourceForSoftwareIdentityProvider.c
<
http://reviewboard-openlmi.rhcloud.com/r/1667/#comment1403>
Please, use LMI_ORGID from the common library.
src/software-dbus/LMI_ResourceForSoftwareIdentityProvider.c
<
http://reviewboard-openlmi.rhcloud.com/r/1667/#comment1404>
LMI_ORGID.
src/software-dbus/LMI_ResourceForSoftwareIdentityProvider.c
<
http://reviewboard-openlmi.rhcloud.com/r/1667/#comment1405>
LMI_ORGID.
src/software-dbus/LMI_ResourceForSoftwareIdentityProvider.c
<
http://reviewboard-openlmi.rhcloud.com/r/1667/#comment1406>
LMI_ORGID.
src/software-dbus/LMI_ResourceForSoftwareIdentityProvider.c
<
http://reviewboard-openlmi.rhcloud.com/r/1667/#comment1407>
There's newly lmi_class_path_is_a() in openlmicommon.
src/software-dbus/sw-utils.h
<
http://reviewboard-openlmi.rhcloud.com/r/1667/#comment1408>
All of these should be already defined by konkret.
src/software-dbus/sw-utils.c
<
http://reviewboard-openlmi.rhcloud.com/r/1667/#comment1409>
lmi_warn().
Perhaps you forgot to rebase before submitting the review?
- Jan Synacek
On May 5, 2014, 5:27 p.m., Peter Schiffer wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1667/
-----------------------------------------------------------
(Updated May 5, 2014, 5:27 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Software-dbus: implemented LMI_ResourceForSoftwareIdentityProvider
Diffs
-----
src/software-dbus/LMI_ResourceForSoftwareIdentityProvider.c
9332f62e392103e39a700cedcfaadf72df8e5f53
src/software-dbus/LMI_SoftwareIdentityProvider.c
7e03badf0113ebc981a24d20ccac60131dfb8d74
src/software-dbus/LMI_SoftwareIdentityResourceProvider.c
fec2794131a6194510364e45969995729e80108c
src/software-dbus/sw-utils.h 16e6ca11e4714ab337c7e554f7c8ced5b06bd37b
src/software-dbus/sw-utils.c 76ca58bd0129c3d12695d22da77fb3613c8685b1
Diff:
http://reviewboard-openlmi.rhcloud.com/r/1667/diff/
Testing
-------
Thanks,
Peter Schiffer