-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1485/#review2216
-----------------------------------------------------------
src/lmi/storage/LMI_LVStorageCapabilities.py
<
http://reviewboard-openlmi.rhcloud.com/r/1485/#comment1194>
CIM_StorageCapabilities describe capabilities of the CIM_StoragePool, i.e. what the
Pool can _create_.
If it is a VG, it can create Thin Pools (ThinlyProvisionedLimitlessStoragePool) and
Logical Volumes (not reflected in SupportedStorageElementTypes).
If it is a Thin Pool, it can create only thin volumes (ThinlyProvisionedStorageExtent;
this is a new vendor ValueMap member as we allocate neither StorageVolumes nor
LogicalDisks).
src/lmi/storage/LMI_StorageConfigurationService.py
<
http://reviewboard-openlmi.rhcloud.com/r/1485/#comment1195>
thinlv.size already is in Blivet size units.
src/lmi/storage/LMI_StorageConfigurationService.py
<
http://reviewboard-openlmi.rhcloud.com/r/1485/#comment1198>
This is weird...
If Pool is specified, then this method _always_ modifies the Pool. You should check if
the parameters are fine and call appropriate modify_vg or modify_thinpool.
If Pool is None, this method always _creates_ new pool. You should check input
parameters and:
- if Goal says that thin pool is requested: create thin pool (and check other params.
accordingly). The _source_ VG is in InPool parameter!
- if goal is None or specifies normal VG: try to create VG (and check other params
accordingly)
src/lmi/storage/LMI_StorageConfigurationService.py
<
http://reviewboard-openlmi.rhcloud.com/r/1485/#comment1199>
isn't this already pushed?
I am not sure now...
- Jan Safranek
On Feb. 3, 2014, 11:34 a.m., Jan Synacek wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1485/
-----------------------------------------------------------
(Updated Feb. 3, 2014, 11:34 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
-------
Add support for thin provisioning.
Currently, only creating / deleting thin pools and thin logical volumes
is supported.
Add some basic tests as well.
Diffs
-----
mof/LMI_Storage-BlockStorage.mof c92081c7539df2409649ad42770f8f9c5e396863
mof/LMI_Storage-MethodParameters.mof cd3cacff1ad2ff12e72d81f1406ca8ed03ccb95b
src/lmi/storage/LMI_LVAllocatedFromStoragePool.py
98d05d28eb1ed377edd85e1a83fc5be03a872a5a
src/lmi/storage/LMI_LVStorageCapabilities.py 95808296456289b3ec7cbfc0a5c81211a573acc6
src/lmi/storage/LMI_LVStorageExtent.py c4f258121396807f60fe9e269a9f1ad59fd20113
src/lmi/storage/LMI_StorageConfigurationService.py
6354d1ac9f2f3ef7d281ed55661d25e950061809
src/lmi/storage/LMI_VGStorageCapabilities.py 966e397d1f961c7ebd6cdbf8fa5707a971b05c0a
src/lmi/storage/LMI_VGStoragePool.py 86a3defeba10330669710395c9884fc016458823
test/test_create_vg.py e650b8123fe178d5a7957d6e8ec898111d63d177
Diff:
http://reviewboard-openlmi.rhcloud.com/r/1485/diff/
Testing
-------
Thanks,
Jan Synacek