On May 6, 2014, 11:21 a.m., Michal Minar wrote:
> src/software-dbus/sw-utils.h, line 193
>
<
http://reviewboard-openlmi.rhcloud.com/r/1667/diff/1/?file=9512#file9512l...
>
> values_p should have const qualifiers since it shall not be changed.
fixed
On May 6, 2014, 11:21 a.m., Michal Minar wrote:
> src/software-dbus/sw-utils.c, line 57
>
<
http://reviewboard-openlmi.rhcloud.com/r/1667/diff/1/?file=9513#file9513l...
>
> splitted -> split
>
> :)
fixed
- Peter
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1667/#review2576
-----------------------------------------------------------
On May 6, 2014, 6:19 p.m., Peter Schiffer wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1667/
-----------------------------------------------------------
(Updated May 6, 2014, 6:19 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Software-dbus: implemented LMI_ResourceForSoftwareIdentityProvider
Diffs
-----
src/software-dbus/LMI_ResourceForSoftwareIdentityProvider.c
9332f62e392103e39a700cedcfaadf72df8e5f53
src/software-dbus/LMI_SoftwareIdentityProvider.c
7e03badf0113ebc981a24d20ccac60131dfb8d74
src/software-dbus/LMI_SoftwareIdentityResourceProvider.c
d321b3035686d67f1cc65c1c3ad2bd11a89602c4
src/software-dbus/sw-utils.h 16e6ca11e4714ab337c7e554f7c8ced5b06bd37b
src/software-dbus/sw-utils.c 76ca58bd0129c3d12695d22da77fb3613c8685b1
Diff:
http://reviewboard-openlmi.rhcloud.com/r/1667/diff/
Testing
-------
Thanks,
Peter Schiffer