This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1667/

On May 6th, 2014, 11:21 a.m. CEST, Michal Minar wrote:

src/software-dbus/sw-utils.h (Diff revision 1)
void create_instance_from_pkgkit_data(PkPackage *pk_pkg, PkDetails *pk_det,
193
void get_pk_det_from_array(char **values_p, GPtrArray **garray, PkTask *task_p);
values_p should have const qualifiers since it shall not be changed.
fixed

On May 6th, 2014, 11:21 a.m. CEST, Michal Minar wrote:

src/software-dbus/sw-utils.c (Diff revision 1)
void free_sw_package(SwPackage *pkg)
57
    gchar **splitted_id = NULL;
splitted -> split

:)
fixed

- Peter


On May 6th, 2014, 6:19 p.m. CEST, Peter Schiffer wrote:

Review request for OpenLMI Developers.
By Peter Schiffer.

Updated May 6, 2014, 6:19 p.m.

Repository: openlmi-providers

Description

Software-dbus: implemented LMI_ResourceForSoftwareIdentityProvider

Diffs

  • src/software-dbus/LMI_ResourceForSoftwareIdentityProvider.c (9332f62e392103e39a700cedcfaadf72df8e5f53)
  • src/software-dbus/LMI_SoftwareIdentityProvider.c (7e03badf0113ebc981a24d20ccac60131dfb8d74)
  • src/software-dbus/LMI_SoftwareIdentityResourceProvider.c (d321b3035686d67f1cc65c1c3ad2bd11a89602c4)
  • src/software-dbus/sw-utils.h (16e6ca11e4714ab337c7e554f7c8ced5b06bd37b)
  • src/software-dbus/sw-utils.c (76ca58bd0129c3d12695d22da77fb3613c8685b1)

View Diff