-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/854/#review1167
-----------------------------------------------------------
src/account/test/testAccount.py
<
http://reviewboard-openlmi.rhcloud.com/r/854/#comment704>
Don't use lmi related code to cleanup.
Instead please use function from methods.py which is included in upstream account
provider test tree.
Use methods like:
clean_account,
src/account/test/testAccount.py
<
http://reviewboard-openlmi.rhcloud.com/r/854/#comment707>
Whitespace on the end of line.
src/account/test/testAccount.py
<
http://reviewboard-openlmi.rhcloud.com/r/854/#comment705>
Whitespace on the end.
src/account/test/testAccount.py
<
http://reviewboard-openlmi.rhcloud.com/r/854/#comment706>
Why is user initialized to None and then replaced by instance?
src/account/test/testAccount.py
<
http://reviewboard-openlmi.rhcloud.com/r/854/#comment708>
Why is there group initialized by None value and then replaced by instance?
src/account/test/testAccount.py
<
http://reviewboard-openlmi.rhcloud.com/r/854/#comment709>
Use hash for instance filters.
If this not work, please fill bug or add bug to comment.
src/account/test/testAccount.py
<
http://reviewboard-openlmi.rhcloud.com/r/854/#comment710>
Why is there double cleaning?
One in the code (using methods from methods.py) and one in tearDown method (still
using openlmi related code).
- Robin Hack
On Sept. 13, 2013, 7:49 a.m., Robin Hack wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/854/
-----------------------------------------------------------
(Updated Sept. 13, 2013, 7:49 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Account: Added QA test for account provider.
Diffs
-----
src/account/test/testAccount.py PRE-CREATION
Diff:
http://reviewboard-openlmi.rhcloud.com/r/854/diff/
Testing
-------
Thanks,
Robin Hack