On May 19, 2014, 9:39 a.m., Michal Minar wrote:
> src/python/lmi/test/ind.py, lines 144-149
>
<
http://reviewboard-openlmi.rhcloud.com/r/1740/diff/1/?file=9884#file9884l...
>
> Seems like run() doesn't accept anything.
Alois Mahdal wrote:
TestDriver.run does:
def run(self, args):
self.args.update(args)
result = self._run()
self._cleanup()
return result
IndicationTestDriver._run (or any *TestDriver._run) does not.
There's intent to keep the driver interface simple and identical over
implementations: Instantiate, call run(case) and, unless you have good reason and you are
very careful, throw away.
Ah, you're right. I thought it refers to local _run() method. It's unfortunate
naming - having run() and _run() implemented in the same class. Could you please move the
comment to the base class instead? Its run() method lacks any docstring. I think it's
more appropriate place for this description.
- Michal
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1740/#review2639
-----------------------------------------------------------
On May 14, 2014, 4:26 p.m., Alois Mahdal wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1740/
-----------------------------------------------------------
(Updated May 14, 2014, 4:26 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Add indication testing framework
Set of classes and methods to help with event stream oritnted
tests.
Diffs
-----
src/account/test/common.py 95abd381089506c3f9b4d6632f2303da322fa585
src/python/lmi/test/ind.py PRE-CREATION
src/python/lmi/test/util.py 699507c2340e9a50ff22ce08b67fe3e0a3f9eef8
Diff:
http://reviewboard-openlmi.rhcloud.com/r/1740/diff/
Testing
-------
Thanks,
Alois Mahdal