-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1741/#review2641
-----------------------------------------------------------
src/account/test/TestIndicationEventStream.py
<
http://reviewboard-openlmi.rhcloud.com/r/1741/#comment1459>
Most of these seem like common options to many other tests. I'd try to move them
somewhere higher in hierarchy to lmi.test package. It would make sense to let them be
overridden by environment variables.
Also name *options* is not much descriptive - especially since they are not used
anywhere in this module (except of being modified in few tests).
src/account/test/TestIndicationEventStream.py
<
http://reviewboard-openlmi.rhcloud.com/r/1741/#comment1460>
Why the leading 'x'?
IMHO it prevents the test from being discovered and run.
src/account/test/TestIndicationEventStream.py
<
http://reviewboard-openlmi.rhcloud.com/r/1741/#comment1461>
Since the order of tests execution is not deterministic, this assignment
nondeterministically affect other tests which do not modify options. Maybe this option
could be passed as a keyword argument to self.assertExpectedStream that would treat them
as additional options to driver.
- Michal Minar
On May 14, 2014, 4:31 p.m., Alois Mahdal wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1741/
-----------------------------------------------------------
(Updated May 14, 2014, 4:31 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Basic set of tests with focus on this flow:
1. add set of subscriptions
2. add set of handlers
3. trigger sequence of "interesting" events
4. collect indications
5. and make assertions as needed
Currently the assertions are mostly that correct classes have been
delivered, reporting the events in correct order.
Diffs
-----
src/account/test/TestIndicationEventStream.py PRE-CREATION
Diff:
http://reviewboard-openlmi.rhcloud.com/r/1741/diff/
Testing
-------
Thanks,
Alois Mahdal